public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/27] mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper
Date: Tue, 7 Oct 2014 08:21:25 +0100	[thread overview]
Message-ID: <20141007072125.GL18035@lee--X1> (raw)
In-Reply-To: <20141006214047.GI18035@lee--X1>

On Mon, 06 Oct 2014, Lee Jones wrote:

> On Wed, 24 Sep 2014, Vinod Koul wrote:
> 
> > Use the new pm_runtime_last_busy_and_autosuspend helper instead of open
> > coding the same code
> > 
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> >  drivers/mfd/ab8500-gpadc.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> Applied with Linus' Ack.

Okay, I just had to search online for the other patches (as you left
me off PATCH 00/27).  It appears this approach has gone down like a
lead balloon.  For this reason I'm pulling these patches from my v3.19
branch.

> > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> > index 36000f9..46bea3a 100644
> > --- a/drivers/mfd/ab8500-gpadc.c
> > +++ b/drivers/mfd/ab8500-gpadc.c
> > @@ -571,8 +571,7 @@ int ab8500_gpadc_double_read_raw(struct ab8500_gpadc *gpadc, u8 channel,
> >  	}
> >  
> >  	/* Disable VTVout LDO this is required for GPADC */
> > -	pm_runtime_mark_last_busy(gpadc->dev);
> > -	pm_runtime_put_autosuspend(gpadc->dev);
> > +	pm_runtime_last_busy_and_autosuspend(gpadc->dev);
> >  
> >  	mutex_unlock(&gpadc->ab8500_gpadc_lock);
> >  
> > @@ -910,8 +909,7 @@ static int ab8500_gpadc_resume(struct device *dev)
> >  	if (ret)
> >  		dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret);
> >  
> > -	pm_runtime_mark_last_busy(gpadc->dev);
> > -	pm_runtime_put_autosuspend(gpadc->dev);
> > +	pm_runtime_last_busy_and_autosuspend(gpadc->dev);
> >  
> >  	mutex_unlock(&gpadc->ab8500_gpadc_lock);
> >  	return ret;
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-10-07  7:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1411575342-31048-1-git-send-email-vinod.koul@intel.com>
2014-09-24 16:14 ` [PATCH 02/27] dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper Vinod Koul
2014-09-25 13:19   ` Linus Walleij
2014-09-24 16:15 ` [PATCH 11/27] mfd: ab8500-gpadc: " Vinod Koul
2014-09-26  8:38   ` Linus Walleij
2014-10-06 21:40   ` Lee Jones
2014-10-07  7:21     ` Lee Jones [this message]
2014-10-07  7:38       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007072125.GL18035@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox