From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: KVM: fix vgic-disabled build
Date: Tue, 7 Oct 2014 12:31:42 +0200 [thread overview]
Message-ID: <20141007103142.GF3717@cbox> (raw)
In-Reply-To: <3777204.xp7MBjnQbJ@wuerfel>
On Tue, Sep 30, 2014 at 01:38:20PM +0200, Arnd Bergmann wrote:
> The vgic code can be disabled in Kconfig and there are dummy implementations
> of most of the provided API functions for the disabled case.
>
> However, the newly introduced kvm_vgic_destroy/kvm_vgic_vcpu_destroy
> functions are lacking those dummies, resulting in this build error:
>
> arch/arm/kvm/arm.c: In function 'kvm_arch_destroy_vm':
> arch/arm/kvm/arm.c:165:2: error: implicit declaration of function 'kvm_vgic_destroy' [-Werror=implicit-function-declaration]
> kvm_vgic_destroy(kvm);
> ^
> arch/arm/kvm/arm.c: In function 'kvm_arch_vcpu_free':
> arch/arm/kvm/arm.c:248:2: error: implicit declaration of function 'kvm_vgic_vcpu_destroy' [-Werror=implicit-function-declaration]
> kvm_vgic_vcpu_destroy(vcpu);
> ^
>
> This adds two inline helpers to get it to build again in this configuration.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c1bfb577add ("arm/arm64: KVM: vgic: switch to dynamic allocation")
Hi Arnd,
Thanks for the fix, it has been applied.
-Christoffer
prev parent reply other threads:[~2014-10-07 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 11:38 [PATCH] ARM: KVM: fix vgic-disabled build Arnd Bergmann
2014-10-07 10:31 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007103142.GF3717@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox