From mboxrd@z Thu Jan  1 00:00:00 1970
From: mark.rutland@arm.com (Mark Rutland)
Date: Tue, 7 Oct 2014 13:08:12 +0100
Subject: [PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix
 with device name to compatible property
In-Reply-To: <11076749.g7xZQflTCQ@wuerfel>
References: <1412682308-8784-1-git-send-email-darshanapadmadas@gmail.com>
 <1412682308-8784-5-git-send-email-darshanapadmadas@gmail.com>
 <11076749.g7xZQflTCQ@wuerfel>
Message-ID: <20141007120812.GJ24725@leverpostej>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:
> On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
> >                 /* ALS and Proximity sensor */
> >                 isl29028 at 44 {
> > -                       compatible = "isil,isl29028";
> > +                       compatible = "isl,isl29028";
> >                         reg = <0x44>;
> >                         interrupt-parent = <&gpio>;
> >                         interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> > 
> 
> Does this intentionally list only the new string?
> 
> If we want compatibility between new dts files and old kernels, this would
> need to be 
> 
> 	compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they
do, but I don't think it should be necessary. Old DTBs should definitely
work with a new kernel, though.

Personally I'd rather see one string (preferably the canonical one, but
the deprecated one is ok) than two strings when those strings are for
the exact same device.

Mark.