* next build: 304 warnings 0 failures (next/next-20141013) [not found] <543b63d2.a479420a.486e.ffffb6e2@mx.google.com> @ 2014-10-13 8:46 ` Russell King - ARM Linux 2014-10-13 9:12 ` Arnd Bergmann 0 siblings, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2014-10-13 8:46 UTC (permalink / raw) To: linux-arm-kernel On Sun, Oct 12, 2014 at 10:32:02PM -0700, Olof's autobuilder wrote: > 1 arch/arm/mach-cns3xxx/pcie.c:313:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] This should be fixed. > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] ... All of these need fixing. > 2 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type > 2 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') This does too. > 3 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type > 3 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') > 8 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type [enabled by default] > 8 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') [enabled by default] > 50 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type [enabled by default] > 50 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') [enabled by default] And these. None of these warnings should hit mainline; they should all be fixed now, before any of the changes which caused them are merged. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 6+ messages in thread
* next build: 304 warnings 0 failures (next/next-20141013) 2014-10-13 8:46 ` next build: 304 warnings 0 failures (next/next-20141013) Russell King - ARM Linux @ 2014-10-13 9:12 ` Arnd Bergmann 2014-10-13 9:38 ` Marek Szyprowski 2014-10-14 8:54 ` Mika Westerberg 0 siblings, 2 replies; 6+ messages in thread From: Arnd Bergmann @ 2014-10-13 9:12 UTC (permalink / raw) To: linux-arm-kernel On Monday 13 October 2014 09:46:18 Russell King - ARM Linux wrote: > On Sun, Oct 12, 2014 at 10:32:02PM -0700, Olof's autobuilder wrote: > > 1 arch/arm/mach-cns3xxx/pcie.c:313:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > This should be fixed. This is an ancient bug, both Mark Brown and I have suggested fixes, we just need to apply one of them. > > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] > > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] > ... > > All of these need fixing. Hadn't seen this one before, I guess it's because of https://lkml.org/lkml/2014/9/16/222. adding Mika and Linus to Cc, should be easy to fix using named initializers like all other 120+ platforms do, but to be on the safe side, we could also move the new 'gpiod' member to the end of 'struct gpio_led'. > > > 2 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type > > 2 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') > > This does too. > > > 3 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type > > 3 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') > > 8 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type [enabled by default] > > 8 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') [enabled by default] > > 50 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type [enabled by default] > > 50 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') [enabled by default] > > And these. > > None of these warnings should hit mainline; they should all be fixed now, > before any of the changes which caused them are merged. Adding Marek as well. No idea how this slipped in, apparently the device_init callback declaration has always used 'void' as the return type, while all functions assigned to it have always returned 'int' and the caller in __reserved_mem_init_node() actually evaluates the return code. This seems to be the obvious fix: diff --git a/include/linux/of_reserved_mem.h b/include/linux/of_reserved_mem.h index 5b5efae09135..3c2cf6fc5e78 100644 --- a/include/linux/of_reserved_mem.h +++ b/include/linux/of_reserved_mem.h @@ -16,7 +16,7 @@ struct reserved_mem { }; struct reserved_mem_ops { - void (*device_init)(struct reserved_mem *rmem, + int (*device_init)(struct reserved_mem *rmem, struct device *dev); void (*device_release)(struct reserved_mem *rmem, struct device *dev); Arnd ^ permalink raw reply related [flat|nested] 6+ messages in thread
* next build: 304 warnings 0 failures (next/next-20141013) 2014-10-13 9:12 ` Arnd Bergmann @ 2014-10-13 9:38 ` Marek Szyprowski 2014-10-14 8:54 ` Mika Westerberg 1 sibling, 0 replies; 6+ messages in thread From: Marek Szyprowski @ 2014-10-13 9:38 UTC (permalink / raw) To: linux-arm-kernel Hello, On 2014-10-13 11:12, Arnd Bergmann wrote: > On Monday 13 October 2014 09:46:18 Russell King - ARM Linux wrote: >> On Sun, Oct 12, 2014 at 10:32:02PM -0700, Olof's autobuilder wrote: >>> 1 arch/arm/mach-cns3xxx/pcie.c:313:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] >> This should be fixed. > This is an ancient bug, both Mark Brown and I have suggested fixes, > we just need to apply one of them. > >>> 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] >>> 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] >>> 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] >>> 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] >> ... >> >> All of these need fixing. > Hadn't seen this one before, I guess it's because of > https://lkml.org/lkml/2014/9/16/222. > > adding Mika and Linus to Cc, should be easy to fix using > named initializers like all other 120+ platforms do, > but to be on the safe side, we could also move the new > 'gpiod' member to the end of 'struct gpio_led'. > >>> 2 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type >>> 2 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') >> This does too. >> >>> 3 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type >>> 3 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') >>> 8 drivers/base/dma-contiguous.c:244:2: warning: initialization from incompatible pointer type [enabled by default] >>> 8 drivers/base/dma-contiguous.c:244:2: warning: (near initialization for 'rmem_cma_ops.device_init') [enabled by default] >>> 50 drivers/base/dma-coherent.c:303:2: warning: initialization from incompatible pointer type [enabled by default] >>> 50 drivers/base/dma-coherent.c:303:2: warning: (near initialization for 'rmem_dma_ops.device_init') [enabled by default] >> And these. >> >> None of these warnings should hit mainline; they should all be fixed now, >> before any of the changes which caused them are merged. > Adding Marek as well. No idea how this slipped in, apparently the device_init > callback declaration has always used 'void' as the return type, while all > functions assigned to it have always returned 'int' and the caller > in __reserved_mem_init_node() actually evaluates the return code. Patches adding of_reservedmem support for dma-contiguous and dma-coherent were posted together with a patch adding a return value. However, for some reasons the latter was dropped. My fault that I've posted that patch in a hurry and missed adding return value check in some places. I've posted a fix and I hope it can get merged as a 'fix': https://lkml.org/lkml/2014/10/9/178 > This seems to be the obvious fix: > > diff --git a/include/linux/of_reserved_mem.h b/include/linux/of_reserved_mem.h > index 5b5efae09135..3c2cf6fc5e78 100644 > --- a/include/linux/of_reserved_mem.h > +++ b/include/linux/of_reserved_mem.h > @@ -16,7 +16,7 @@ struct reserved_mem { > }; > > struct reserved_mem_ops { > - void (*device_init)(struct reserved_mem *rmem, > + int (*device_init)(struct reserved_mem *rmem, > struct device *dev); > void (*device_release)(struct reserved_mem *rmem, > struct device *dev); > > > Arnd > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 6+ messages in thread
* next build: 304 warnings 0 failures (next/next-20141013) 2014-10-13 9:12 ` Arnd Bergmann 2014-10-13 9:38 ` Marek Szyprowski @ 2014-10-14 8:54 ` Mika Westerberg 2014-10-14 9:17 ` Arnd Bergmann 1 sibling, 1 reply; 6+ messages in thread From: Mika Westerberg @ 2014-10-14 8:54 UTC (permalink / raw) To: linux-arm-kernel On Mon, Oct 13, 2014 at 11:12:46AM +0200, Arnd Bergmann wrote: > On Monday 13 October 2014 09:46:18 Russell King - ARM Linux wrote: > > On Sun, Oct 12, 2014 at 10:32:02PM -0700, Olof's autobuilder wrote: > > > 1 arch/arm/mach-cns3xxx/pcie.c:313:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > This should be fixed. > > This is an ancient bug, both Mark Brown and I have suggested fixes, > we just need to apply one of them. > > > > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > > 1 arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] > > > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > > 1 arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] > > ... > > > > All of these need fixing. > > Hadn't seen this one before, I guess it's because of > https://lkml.org/lkml/2014/9/16/222. > > adding Mika and Linus to Cc, should be easy to fix using > named initializers like all other 120+ platforms do, > but to be on the safe side, we could also move the new > 'gpiod' member to the end of 'struct gpio_led'. (+Rafael) Fenghua's build bot noticed this some time ago and it got fixed but looks like we forgot to merge the fix to the _DSD patch series. Here it is again. Rafael, do you want to take this on top of the 'device-properties' -branch? From: Mika Westerberg <mika.westerberg@linux.intel.com> Subject: [PATCH] leds: Move gpiod to be last member of struct gpio_led Commit 8b0d4dc3d44 (leds: leds-gpio: Add support for GPIO descriptors) added a new member 'gpiod' to struct gpio_led to support GPIO descriptors. This is fine as long as board files use designated initializers but some fail to do so causing following build errors: arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] To be on the safe side move the 'gpiod' member to be the last member of struct gpiod_led. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- include/linux/leds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/leds.h b/include/linux/leds.h index 7852b9365113..f3af5c4d9084 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -256,12 +256,12 @@ struct led_platform_data { struct gpio_led { const char *name; const char *default_trigger; - struct gpio_desc *gpiod; unsigned gpio; unsigned active_low : 1; unsigned retain_state_suspended : 1; unsigned default_state : 2; /* default_state should be one of LEDS_GPIO_DEFSTATE_(ON|OFF|KEEP) */ + struct gpio_desc *gpiod; }; #define LEDS_GPIO_DEFSTATE_OFF 0 #define LEDS_GPIO_DEFSTATE_ON 1 -- 2.1.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* next build: 304 warnings 0 failures (next/next-20141013) 2014-10-14 8:54 ` Mika Westerberg @ 2014-10-14 9:17 ` Arnd Bergmann 2014-10-14 13:16 ` Mika Westerberg 0 siblings, 1 reply; 6+ messages in thread From: Arnd Bergmann @ 2014-10-14 9:17 UTC (permalink / raw) To: linux-arm-kernel On Tuesday 14 October 2014 11:54:32 Mika Westerberg wrote: > > Fenghua's build bot noticed this some time ago and it got fixed but > looks like we forgot to merge the fix to the _DSD patch series. > > Here it is again. Rafael, do you want to take this on top of the > 'device-properties' -branch? > > From: Mika Westerberg <mika.westerberg@linux.intel.com> > Subject: [PATCH] leds: Move gpiod to be last member of struct gpio_led > > Commit 8b0d4dc3d44 (leds: leds-gpio: Add support for GPIO descriptors) > added a new member 'gpiod' to struct gpio_led to support GPIO descriptors. > This is fine as long as board files use designated initializers but some > fail to do so causing following build errors: > > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] > > To be on the safe side move the 'gpiod' member to be the last member of struct > gpiod_led. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> Looks good to me. Should we also do the other patch to be on the safe side? 8<------- Subject: [PATCH] ARM: OMAP1: htcherald: use named initializers for gpio-leds A recent change to the gpio-leds driver broke the platform data definition in the htcherald file: arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] The gpio-led driver is being changed to avoid that problem, but it would also be good to make the board file use named initializers like every other one, so it won't happen again. Signed-off-by: Arnd Bergmann <arnd@arndb.de> diff --git a/arch/arm/mach-omap1/board-htcherald.c b/arch/arm/mach-omap1/board-htcherald.c index 35a2379b986f..259a54733e63 100644 --- a/arch/arm/mach-omap1/board-htcherald.c +++ b/arch/arm/mach-omap1/board-htcherald.c @@ -293,17 +293,18 @@ static struct platform_device herald_gpiokeys_device = { /* LEDs for the Herald. These connect to the HTCPLD GPIO device. */ static struct gpio_led gpio_leds[] = { - {"dpad", NULL, HTCPLD_GPIO_LED_DPAD, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"kbd", NULL, HTCPLD_GPIO_LED_KBD, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"vibrate", NULL, HTCPLD_GPIO_LED_VIBRATE, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"green_solid", NULL, HTCPLD_GPIO_LED_GREEN_SOLID, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"green_flash", NULL, HTCPLD_GPIO_LED_GREEN_FLASH, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"red_solid", "mmc0", HTCPLD_GPIO_LED_RED_SOLID, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"red_flash", NULL, HTCPLD_GPIO_LED_RED_FLASH, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"wifi", NULL, HTCPLD_GPIO_LED_WIFI, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"bt", NULL, HTCPLD_GPIO_LED_BT, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"caps", NULL, HTCPLD_GPIO_LED_CAPS, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, - {"alt", NULL, HTCPLD_GPIO_LED_ALT, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, + { .name = "dpad", .gpio = HTCPLD_GPIO_LED_DPAD, }, + { .name = "kbd", .gpio = HTCPLD_GPIO_LED_KBD, }, + { .name = "vibrate", .gpio = HTCPLD_GPIO_LED_VIBRATE, }, + { .name = "green_solid", .gpio = HTCPLD_GPIO_LED_GREEN_SOLID, }, + { .name = "green_flash", .gpio = HTCPLD_GPIO_LED_GREEN_FLASH, }, + { .name = "red_solid", .default_trigger = "mmc0", + .gpio = HTCPLD_GPIO_LED_RED_SOLID, }, + { .name = "red_flash", .gpio = HTCPLD_GPIO_LED_RED_FLASH, }, + { .name = "wifi", .gpio = HTCPLD_GPIO_LED_WIFI, }, + { .name = "bt", .gpio = HTCPLD_GPIO_LED_BT, }, + { .name = "caps", .gpio = HTCPLD_GPIO_LED_CAPS, }, + { .name = "alt", .gpio = HTCPLD_GPIO_LED_ALT, }, }; static struct gpio_led_platform_data gpio_leds_data = { ^ permalink raw reply related [flat|nested] 6+ messages in thread
* next build: 304 warnings 0 failures (next/next-20141013) 2014-10-14 9:17 ` Arnd Bergmann @ 2014-10-14 13:16 ` Mika Westerberg 0 siblings, 0 replies; 6+ messages in thread From: Mika Westerberg @ 2014-10-14 13:16 UTC (permalink / raw) To: linux-arm-kernel On Tue, Oct 14, 2014 at 11:17:33AM +0200, Arnd Bergmann wrote: > On Tuesday 14 October 2014 11:54:32 Mika Westerberg wrote: > > > > Fenghua's build bot noticed this some time ago and it got fixed but > > looks like we forgot to merge the fix to the _DSD patch series. > > > > Here it is again. Rafael, do you want to take this on top of the > > 'device-properties' -branch? > > > > From: Mika Westerberg <mika.westerberg@linux.intel.com> > > Subject: [PATCH] leds: Move gpiod to be last member of struct gpio_led > > > > Commit 8b0d4dc3d44 (leds: leds-gpio: Add support for GPIO descriptors) > > added a new member 'gpiod' to struct gpio_led to support GPIO descriptors. > > This is fine as long as board files use designated initializers but some > > fail to do so causing following build errors: > > > > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default] > > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default] > > > > To be on the safe side move the 'gpiod' member to be the last member of struct > > gpiod_led. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Looks good to me. Should we also do the other patch to be on the safe side? I think it is good idea. > 8<------- > Subject: [PATCH] ARM: OMAP1: htcherald: use named initializers for gpio-leds > > A recent change to the gpio-leds driver broke the platform data definition > in the htcherald file: > > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default] > > The gpio-led driver is being changed to avoid that problem, but it would also > be good to make the board file use named initializers like every other one, > so it won't happen again. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> FWIW, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-14 13:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <543b63d2.a479420a.486e.ffffb6e2@mx.google.com>
2014-10-13 8:46 ` next build: 304 warnings 0 failures (next/next-20141013) Russell King - ARM Linux
2014-10-13 9:12 ` Arnd Bergmann
2014-10-13 9:38 ` Marek Szyprowski
2014-10-14 8:54 ` Mika Westerberg
2014-10-14 9:17 ` Arnd Bergmann
2014-10-14 13:16 ` Mika Westerberg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).