linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
Date: Tue, 14 Oct 2014 14:40:48 -0700	[thread overview]
Message-ID: <20141014144048.e2bf1f5ec23c39d2a59700f6@linux-foundation.org> (raw)
In-Reply-To: <543694F4.3070306@linux.vnet.ibm.com>

On Thu, 09 Oct 2014 16:00:20 +0200 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:

> Looks good. Andrew, can you pick this change up via your tree?
> 

Sure.

> 
> On 09.10.2014 12:54, Riku Voipio wrote:
> > Following up the arm testing of gcov, turns out gcov on ARM64
> > works fine as well. Only change needed is adding ARM64 to Kconfig
> > depends.
> > 
> > Tested with qemu and mach-virt
> > 
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > ---
> >  kernel/gcov/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index cf66c5c..3b74087 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> >  config GCOV_PROFILE_ALL
> >  	bool "Profile entire Kernel"
> >  	depends on GCOV_KERNEL
> > -	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > +	depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> >  	default n
> >  	---help---
> >  	This options activates profiling for the entire kernel.

gcov is doing this the wrong way.  There should be a `select
GCOV_PROFILE_ALL' in each arch/*/Kconfig.

(But pleeeeeeze not at the end of the list!  That's the perfect way of
maximizing patch conflicts, but nobody seems to understand this)

  reply	other threads:[~2014-10-14 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 10:54 [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL Riku Voipio
2014-10-09 14:00 ` Peter Oberparleiter
2014-10-14 21:40   ` Andrew Morton [this message]
2014-10-14 21:54     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2014-10-16 13:46 Riku Voipio
2014-10-16 14:01 ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014144048.e2bf1f5ec23c39d2a59700f6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).