linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] iommu: Implement a dummy bus_set_iommu()
Date: Wed, 15 Oct 2014 11:10:44 +0200	[thread overview]
Message-ID: <20141015091043.GA13162@ulmo> (raw)
In-Reply-To: <20140818165750.GE9809@8bytes.org>

On Mon, Aug 18, 2014 at 06:57:50PM +0200, Joerg Roedel wrote:
> On Fri, Aug 01, 2014 at 02:45:13PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > This allows IOMMU drivers to compile even if IOMMU_API is not selected
> > and helps improve compile coverage.
> 
> IOMMU drivers usually implement the IOMMU-API, so they have a strong
> dependency to it. Why do you want to compile-test an iommu driver
> without testing the iommu core-code as well?

It seems like I never got back to you on this. The reason here is that
for Tegra the IOMMU is part of a larger IP block. The IP block is
primarily a memory controller with a bunch of configuration knobs for
arbitration, prioritization and whatnot. A smaller part of the device
does the IOMMU translation. Therefore the IOMMU implementation would
be part of a larger driver, and having this dummy would reduce the
amount of #ifdefs required.

bus_set_iommu() is also the only function in include/linux/iommu.h that
doesn't have a dummy, so it seemed like a natural thing to do.

That said, I can work around this being absent for !IOMMU_API.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141015/cc11222d/attachment.sig>

  reply	other threads:[~2014-10-15  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 12:45 [PATCH 1/2] iommu: Always define struct iommu_ops Thierry Reding
2014-08-01 12:45 ` [PATCH 2/2] iommu: Implement a dummy bus_set_iommu() Thierry Reding
2014-08-18 16:57   ` Joerg Roedel
2014-10-15  9:10     ` Thierry Reding [this message]
2014-10-22 14:29       ` Joerg Roedel
2014-10-23  8:09         ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015091043.GA13162@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).