linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: exynos7: add support for cpuidle core power down
Date: Wed, 15 Oct 2014 15:07:59 +0100	[thread overview]
Message-ID: <20141015140759.GB26484@red-moon> (raw)
In-Reply-To: <20141015130218.GB20034@leverpostej>

On Wed, Oct 15, 2014 at 02:02:18PM +0100, Mark Rutland wrote:
> > > +			CPU_SLEEP: cpu-sleep {
> > > +				compatible = "arm,idle-state";
> > > +				local-timer-stop;
> > > +				arm,psci-suspend-param = <0x0010000>;
> > > +				entry-latency-us = <20>;
> > > +				exit-latency-us = <150>;
> > > +				min-residency-us = <2100>;
> > > +				status = "enabled";
> 
> While status is a relatively standard property, it's absence implies
> everything is OK. There no need for it here as-is.
> 
> Additionally, the canonical value is "okay", not "enabled", so this
> would fail were we to use of_device_is_available in the idle states
> parsing.

Good point. I still want it documented in the bindings, keeping in mind
your remark above.

> > status ? This is not a documented property. If you need it please explain
> > why, define its bindings and we can see how to accommodate it.
> 
> Do we expect that some idle states won't be available on some boards
> built from the same platform?

I think it is something we should expect and be able to cope with that.

I will add status to idle-states bindings updates for this cycle and patch DT
parsing code accordingly.

Lorenzo

  reply	other threads:[~2014-10-15 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15  6:35 [PATCH] arm64: dts: exynos7: add support for cpuidle core power down Chander Kashyap
2014-10-15  9:00 ` Lorenzo Pieralisi
2014-10-15 13:02   ` Mark Rutland
2014-10-15 14:07     ` Lorenzo Pieralisi [this message]
2014-10-17  9:43   ` Chander Kashyap
2014-10-21 16:33     ` Lorenzo Pieralisi
2014-11-05 10:01       ` Chander Kashyap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015140759.GB26484@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).