From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi/atmel: add support for runtime PM
Date: Thu, 16 Oct 2014 09:30:04 +0200 [thread overview]
Message-ID: <20141016073004.GL27755@sirena.org.uk> (raw)
In-Reply-To: <1413424160-21180-1-git-send-email-wenyou.yang@atmel.com>
On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote:
> +static int atmel_spi_runtime_resume(struct device *dev)
> +{
> + struct spi_master *master = dev_get_drvdata(dev);
> + struct atmel_spi *as = spi_master_get_devdata(master);
> +
> + pinctrl_pm_select_default_state(dev);
> + clk_prepare_enable(as->clk);
> +
This looks mostly good but you should check the return value of
clk_prepare_enable() - it can fail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/49d90527/attachment.sig>
next prev parent reply other threads:[~2014-10-16 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 1:49 [PATCH] spi/atmel: add support for runtime PM Wenyou Yang
2014-10-16 7:30 ` Mark Brown [this message]
2014-10-16 8:09 ` Yang, Wenyou
2014-10-17 13:02 ` Kevin Hilman
2014-10-17 13:57 ` Mark Brown
2014-10-17 14:22 ` Kevin Hilman
2014-10-17 14:31 ` Mark Brown
2014-10-20 2:05 ` Yang, Wenyou
2014-10-20 18:09 ` Kevin Hilman
2014-10-21 0:51 ` Yang, Wenyou
2014-10-20 1:59 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016073004.GL27755@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).