[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[Olof Johansson]

Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
the select of REGULATOR, which means that it now has to be explicitly
enabled in the defconfig or things won't work very well.

In particular, this fixes a problem with SD/MMC not probing on my A31-based
board.

Cc: Beniamino Galvani <b.galvani@gmail.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
---

Maxime, I'll apply this on our fixes branch directly.

 arch/arm/configs/sunxi_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index c1a4ca4f6e6d..847045313101 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -75,6 +75,7 @@ CONFIG_POWER_RESET_SUN6I=y
 CONFIG_WATCHDOG=y
 CONFIG_SUNXI_WATCHDOG=y
 CONFIG_MFD_AXP20X=y
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
-- 
2.0.1.473.gc4d58ca

[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[Maxime Ripard]

Hi Olof,

On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
> Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
> the select of REGULATOR, which means that it now has to be explicitly
> enabled in the defconfig or things won't work very well.
> 
> In particular, this fixes a problem with SD/MMC not probing on my A31-based
> board.
> 
> Cc: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> 
> Maxime, I'll apply this on our fixes branch directly.

I've been chasing the same bug, but didn't make a patch yet. Thanks
for taking the time to do it!

If it's not applied yet, you have my
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/629fbef0/attachment.sig>

[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[Beniamino Galvani]

On Thu, Oct 16, 2014 at 10:04:48AM +0200, Maxime Ripard wrote:
> Hi Olof,
> 
> On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
> > Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
> > the select of REGULATOR, which means that it now has to be explicitly
> > enabled in the defconfig or things won't work very well.
> > 
> > In particular, this fixes a problem with SD/MMC not probing on my A31-based
> > board.
> > 
> > Cc: Beniamino Galvani <b.galvani@gmail.com>
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> > ---
> > 
> > Maxime, I'll apply this on our fixes branch directly.
> 
> I've been chasing the same bug, but didn't make a patch yet. Thanks
> for taking the time to do it!
> 
> If it's not applied yet, you have my
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Sorry for the breakage, I didn't realize that some configurations
could rely on the implicit selection of the symbol.

Beniamino

[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[Maxime Ripard]

On Thu, Oct 16, 2014 at 12:47:17PM +0200, Beniamino Galvani wrote:
> On Thu, Oct 16, 2014 at 10:04:48AM +0200, Maxime Ripard wrote:
> > Hi Olof,
> > 
> > On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
> > > Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
> > > the select of REGULATOR, which means that it now has to be explicitly
> > > enabled in the defconfig or things won't work very well.
> > > 
> > > In particular, this fixes a problem with SD/MMC not probing on my A31-based
> > > board.
> > > 
> > > Cc: Beniamino Galvani <b.galvani@gmail.com>
> > > Signed-off-by: Olof Johansson <olof@lixom.net>
> > > ---
> > > 
> > > Maxime, I'll apply this on our fixes branch directly.
> > 
> > I've been chasing the same bug, but didn't make a patch yet. Thanks
> > for taking the time to do it!
> > 
> > If it's not applied yet, you have my
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Sorry for the breakage, I didn't realize that some configurations
> could rely on the implicit selection of the symbol.

Don't worry, it's fine, it's why we have a bugfix period and boots
testing for :)

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/0c8648c2/attachment.sig>

[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

[Olof Johansson]

On Thu, Oct 16, 2014 at 4:46 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Oct 16, 2014 at 12:47:17PM +0200, Beniamino Galvani wrote:
>> On Thu, Oct 16, 2014 at 10:04:48AM +0200, Maxime Ripard wrote:
>> > Hi Olof,
>> >
>> > On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
>> > > Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
>> > > the select of REGULATOR, which means that it now has to be explicitly
>> > > enabled in the defconfig or things won't work very well.
>> > >
>> > > In particular, this fixes a problem with SD/MMC not probing on my A31-based
>> > > board.
>> > >
>> > > Cc: Beniamino Galvani <b.galvani@gmail.com>
>> > > Signed-off-by: Olof Johansson <olof@lixom.net>
>> > > ---
>> > >
>> > > Maxime, I'll apply this on our fixes branch directly.
>> >
>> > I've been chasing the same bug, but didn't make a patch yet. Thanks
>> > for taking the time to do it!
>> >
>> > If it's not applied yet, you have my
>> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> Sorry for the breakage, I didn't realize that some configurations
>> could rely on the implicit selection of the symbol.
>
> Don't worry, it's fine, it's why we have a bugfix period and boots
> testing for :)

Yep, no worries.

However, it doesn't seem to have been enough and I don't know how I
made the test pass the first time when I checked the fix.  Looks like
it needs REGULATOR_FIXED_VOLTAGE too, and I didn't catch it before I
sent out the pull request. D'oh.

I'll fix it for -rc2.


-Olof