linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Latest build test randconfig errors
@ 2014-10-16  8:31 Russell King - ARM Linux
  2014-10-16 13:40 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Russell King - ARM Linux @ 2014-10-16  8:31 UTC (permalink / raw)
  To: linux-arm-kernel

The cause seems to be a missing dependency between the Tegra DRM
code and COMMON_CLK, caused by:

commit 158b50aefa14ba18ee94b691f83a7e5d30539433
Author: Thierry Reding <treding@nvidia.com>
Date:   Wed Nov 20 20:39:35 2013 +0100

    drm/tegra: Increase compile test coverage

ARCH_MULTIPLATFORM would have selected COMMON_CLK, and ARCH_TEGRA
requires ARCH_MULTIPLATFORM to be set so that part was redundant
in the original dependencies:

menuconfig ARCH_TEGRA
        bool "NVIDIA Tegra" if ARCH_MULTI_V7

Here's the errors:

drivers/built-in.o: In function `tegra_output_rgb_setup_clock':
debugfs.c:(.text+0x9b5d0): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_dc_rgb_probe':
debugfs.c:(.text+0x9b6a0): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_output_hdmi_check_mode':
debugfs.c:(.text+0x9b9e0): undefined reference to `clk_get_parent'
drivers/built-in.o: In function `tegra_output_hdmi_setup_clock':
debugfs.c:(.text+0x9ba24): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_hdmi_probe':
debugfs.c:(.text+0x9da80): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_output_dsi_setup_clock':
debugfs.c:(.text+0x9e12c): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_dsi_probe':
debugfs.c:(.text+0x9f374): undefined reference to `clk_get_parent'
debugfs.c:(.text+0x9f384): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_output_sor_disable':
debugfs.c:(.text+0x9f860): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_output_sor_setup_clock':
debugfs.c:(.text+0x9ff00): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `tegra_output_sor_enable':
debugfs.c:(.text+0xa0318): undefined reference to `clk_set_parent'
drivers/built-in.o: In function `hdmi_runtime_resume':
debugfs.c:(.text+0x2653e0): undefined reference to `clk_set_parent'
drivers/built-in.o:debugfs.c:(.text+0x2662c4): more undefined references to `clk_set_parent' follow
make[1]: *** [vmlinux] Error 1
make[1]: Target `uImage' not remade because of errors.
make: *** [sub-make] Error 2
make: Target `uImage' not remade because of errors.
make: Target `dtbs' not remade because of errors.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Latest build test randconfig errors
  2014-10-16  8:31 Latest build test randconfig errors Russell King - ARM Linux
@ 2014-10-16 13:40 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2014-10-16 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Oct 16, 2014 at 09:31:20AM +0100, Russell King - ARM Linux wrote:
> The cause seems to be a missing dependency between the Tegra DRM
> code and COMMON_CLK, caused by:
> 
> commit 158b50aefa14ba18ee94b691f83a7e5d30539433
> Author: Thierry Reding <treding@nvidia.com>
> Date:   Wed Nov 20 20:39:35 2013 +0100
> 
>     drm/tegra: Increase compile test coverage
> 
> ARCH_MULTIPLATFORM would have selected COMMON_CLK, and ARCH_TEGRA
> requires ARCH_MULTIPLATFORM to be set so that part was redundant
> in the original dependencies:
> 
> menuconfig ARCH_TEGRA
>         bool "NVIDIA Tegra" if ARCH_MULTI_V7

I've queued the following fix for this. As I understand that should fix
this particular issue.

diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 354ddb29231f..74d9d621453d 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -1,6 +1,7 @@
 config DRM_TEGRA
 	tristate "NVIDIA Tegra DRM"
 	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+	depends on COMMON_CLK
 	depends on DRM
 	depends on RESET_CONTROLLER
 	select DRM_KMS_HELPER

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/8dd80525/attachment.sig>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-16 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16  8:31 Latest build test randconfig errors Russell King - ARM Linux
2014-10-16 13:40 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).