From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Date: Thu, 16 Oct 2014 13:46:24 +0200 [thread overview]
Message-ID: <20141016114624.GI19438@lukather> (raw)
In-Reply-To: <20141016104716.GA15929@gmail.com>
On Thu, Oct 16, 2014 at 12:47:17PM +0200, Beniamino Galvani wrote:
> On Thu, Oct 16, 2014 at 10:04:48AM +0200, Maxime Ripard wrote:
> > Hi Olof,
> >
> > On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
> > > Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
> > > the select of REGULATOR, which means that it now has to be explicitly
> > > enabled in the defconfig or things won't work very well.
> > >
> > > In particular, this fixes a problem with SD/MMC not probing on my A31-based
> > > board.
> > >
> > > Cc: Beniamino Galvani <b.galvani@gmail.com>
> > > Signed-off-by: Olof Johansson <olof@lixom.net>
> > > ---
> > >
> > > Maxime, I'll apply this on our fixes branch directly.
> >
> > I've been chasing the same bug, but didn't make a patch yet. Thanks
> > for taking the time to do it!
> >
> > If it's not applied yet, you have my
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Sorry for the breakage, I didn't realize that some configurations
> could rely on the implicit selection of the symbol.
Don't worry, it's fine, it's why we have a bugfix period and boots
testing for :)
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/0c8648c2/attachment.sig>
next prev parent reply other threads:[~2014-10-16 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 6:29 [PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR Olof Johansson
2014-10-16 8:04 ` Maxime Ripard
2014-10-16 10:47 ` Beniamino Galvani
2014-10-16 11:46 ` Maxime Ripard [this message]
2014-10-19 21:24 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016114624.GI19438@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox