linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Blacklist GCC 4.8.0 to GCC 4.8.2 - PR58854
Date: Fri, 17 Oct 2014 14:41:12 +0100	[thread overview]
Message-ID: <20141017134112.GS12379@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.11.1410161052520.9094@knanqh.ubzr>

On Thu, Oct 16, 2014 at 10:58:06AM -0400, Nicolas Pitre wrote:
> On Thu, 16 Oct 2014, Russell King - ARM Linux wrote:
> 
> > So, let me put this another way: a compiler with this bug is _completely_
> > unsuitable for use for compiling programs for use under the Linux
> > kernel _as well_ as the Linux kernel itself.
> > 
> > The difference is that the Linaro compilers come with an expectation
> > that they are usable on ARM... whereas stock versions cover a lot more
> > and so the ARM arch is probably very small number of their users.
> > 
> > Hence why I recommend that Linaro takes down their buggy compiler.
> > Their 4.8.3 version should not be used *anywhere*, just the same as
> > the stock 4.8 to 4.8.2 inclusive should also not be used anywhere on
> > ARM either.
> 
> Here's the answer from the toolchain team:
> 
> On Thu, 16 Oct 2014, Yvan Roux <yvan.roux@linaro.org> wrote:
> 
> | Hi Nicolas,
> |
> | thanks for bringing this to our knowledge.
> |
> | The fix for PR58854 was included in our releases since the GCC
> | 4.8-2013.12 which is based on a 4.8.3 prerelease version (at svn
> | revision 205577).  As we are doing monthly releases based on a
> | revision of the related FSF branch, using GCC_VERSION (__GNUC__,
> | __GNUC_MINOR,__GNUC_PATCHLEVEL) is not accurate enough to identify the
> | release version (all our releases between November 2013 and May 2014
> | will be 4.8.3) the __VERSION__ predefined macro is a bit more accurate
> | here ("4.8.3 20131202 (prerelease)") but not completely satisfactory.
> |
> | I completely agree that we should at least mention in our impacted
> | releases download pages that this bug is present.

Unfortunately, __VERSION__ doesn't help us identify that the bug has
been fixed - it's not something which can be tested at preprocessor
time.

Those which identify themselves as 4.8.3 won't be impacted by the patch,
which means that the Linaro 4.8.3 GCC versions will continue to build
the kernel just fine.  Even the buggy versions.

I don't see the point of continuing to offer the buggy versions for
download though - the compiler is totally unsuitable for building any
Linux related binaries, be that kernel or userspace, and so should not
be used under any circumstances, period.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2014-10-17 13:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 21:56 [PATCH] ARM: Blacklist GCC 4.8.0 to GCC 4.8.2 - PR58854 Russell King
2014-10-15 22:18 ` Peter Hurley
2014-10-16  0:18   ` Russell King - ARM Linux
2014-10-16  0:44     ` Peter Hurley
2014-10-16 14:58     ` Nicolas Pitre
2014-10-17 13:41       ` Russell King - ARM Linux [this message]
2014-10-19  9:55         ` Russell King - ARM Linux
     [not found]           ` <CA+55aFw_N=E9O-7VknWTzjNgYG-tB-8736diA1r7K=50b+0czQ@mail.gmail.com>
2014-10-19 18:51             ` Russell King - ARM Linux
2014-10-19 20:04               ` Linus Torvalds
2014-10-19 20:14                 ` Russell King - ARM Linux
2014-10-19 20:28                   ` Olof Johansson
2014-10-16 10:30 ` David Laight
2014-10-16 14:29   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141017134112.GS12379@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).