From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] m25p80,spi-nor: Fix module aliases for m25p80
Date: Fri, 17 Oct 2014 09:23:35 -0700 [thread overview]
Message-ID: <20141017162335.GG22169@norris-Latitude-E6410> (raw)
In-Reply-To: <20141010045126.GB22169@norris-Latitude-E6410>
On Thu, Oct 09, 2014 at 09:51:26PM -0700, Brian Norris wrote:
> On Tue, Sep 30, 2014 at 03:14:55AM +0100, Ben Hutchings wrote:
> > m25p80's device ID table is now spi_nor_ids, defined in spi-nor. The
> > MODULE_DEVICE_TABLE() macro doesn't work with extern definitions, but
> > its use was also removed at the same time. Now if m25p80 is built as
> > a module it doesn't get the necessary aliases to be loaded
> > automatically.
> >
> > A clean solution to this will involve defining the list of device
> > IDs in spi-nor.h and removing struct spi_device_id from the spi-nor
> > API, but this is quite a large change.
> >
> > As a quick fix suitable for stable, copy the device IDs back into
> > m25p80.
> >
> > Fixes: 03e296f613af ("mtd: m25p80: use the SPI nor framework")
> > Cc: stable <stable@vger.kernel.org> # 3.16.x: 32f1b7c8352f: mtd: move support for struct flash_platform_data into m25p80
> > Cc: stable <stable@vger.kernel.org> # 3.16.x
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
> Can I get any acks/tested-by's? I'll try to test this out when I get
> back to the office, but I'd like to be able to send this in the 3.18
> cycle still.
Applied this patch to l2-mtd/master. Thanks!
Acks/tested-by's are still welcome. I plan to send this out in 3.18
(maybe for -rc2) if things look good.
Brian
next prev parent reply other threads:[~2014-10-17 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 2:13 [PATCH v2 0/5] m25p80,spi-nor: Fix module aliases for m25p80; clean up chip identification Ben Hutchings
2014-09-30 2:14 ` [PATCH v2 1/5] m25p80,spi-nor: Fix module aliases for m25p80 Ben Hutchings
2014-10-10 4:51 ` Brian Norris
2014-10-17 16:23 ` Brian Norris [this message]
2014-10-17 16:35 ` Brian Norris
2014-10-17 16:41 ` Ben Hutchings
2014-09-30 2:15 ` [PATCH v2 2/5] spi-nor: Remove spi_nor::read_id operation Ben Hutchings
2014-10-22 8:30 ` Brian Norris
2014-09-30 2:15 ` [PATCH v2 3/5] spi-nor: Make spi_nor_scan() take a chip type name, not an spi_device_id Ben Hutchings
2014-09-30 5:14 ` Rafał Miłecki
2014-09-30 11:38 ` Ben Hutchings
2014-09-30 2:15 ` [PATCH v2 4/5] spi-nor: Replace struct spi_device_id with struct flash_info Ben Hutchings
2014-09-30 2:15 ` [PATCH v2 5/5] m25p80,spi-nor: Share the list of supported chip type names again Ben Hutchings
2014-09-30 7:22 ` Geert Uytterhoeven
2014-09-30 8:02 ` Rafał Miłecki
2014-09-30 11:36 ` Ben Hutchings
2014-10-10 4:55 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017162335.GG22169@norris-Latitude-E6410 \
--to=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox