From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 1/6] ARM: dts: Add SoC level device tree support for LS1021A
Date: Sun, 19 Oct 2014 09:37:02 +0800 [thread overview]
Message-ID: <20141019013701.GC7869@tiger> (raw)
In-Reply-To: <1413192963-11153-2-git-send-email-jingchang.lu@freescale.com>
On Mon, Oct 13, 2014 at 05:35:58PM +0800, Jingchang Lu wrote:
> +/ {
> + compatible = "fsl,ls1021a";
> + interrupt-parent = <&gic>;
> +
> + aliases {
> + serial0 = &lpuart0;
> + serial1 = &lpuart1;
> + serial2 = &lpuart2;
> + serial3 = &lpuart3;
> + serial4 = &lpuart4;
> + serial5 = &lpuart5;
> + sysclk = &sysclk;
What is this sysclk aliase used for?
> + };
Bad indent.
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu at f00 {
> + compatible = "arm,cortex-a7";
> + device_type = "cpu";
> + reg = <0xf00>;
> + };
> +
> + cpu at f01 {
> + compatible = "arm,cortex-a7";
> + device_type = "cpu";
> + reg = <0xf01>;
> + };
> + };
> +
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
I like this indent style ...
> + };
> +
> + pmu {
> + compatible = "arm,cortex-a7-pmu";
> + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
... not this style. Please fix such indents through the file.
> + };
Shawn
next prev parent reply other threads:[~2014-10-19 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 9:35 [PATCHv5 0/6] ARM: imx: Add Freescale LS1021A SoC and board support Jingchang Lu
2014-10-13 9:35 ` [PATCHv5 1/6] ARM: dts: Add SoC level device tree support for LS1021A Jingchang Lu
2014-10-19 1:17 ` Shawn Guo
2014-10-19 19:17 ` Arnd Bergmann
2014-10-19 1:37 ` Shawn Guo [this message]
2014-10-21 1:53 ` Jingchang Lu
2014-10-13 9:35 ` [PATCHv5 2/6] ARM: dts: Add initial LS1021A QDS board dts support Jingchang Lu
2014-10-19 1:44 ` Shawn Guo
2014-10-13 9:36 ` [PATCHv5 3/6] ARM: dts: Add initial LS1021A TWR " Jingchang Lu
2014-10-19 1:49 ` Shawn Guo
2014-10-13 9:36 ` [PATCHv5 4/6] dt-bindings: arm: add Freescale LS1021A SoC device tree binding Jingchang Lu
2014-10-13 9:36 ` [PATCHv5 5/6] ARM: imx: Add initial support for Freescale LS1021A Jingchang Lu
2014-10-13 9:36 ` [PATCHv5 6/6] ARM: imx: Add Freescale LS1021A SMP support Jingchang Lu
2014-10-16 14:30 ` Kumar Gala
2014-10-17 10:10 ` Jingchang Lu
2014-10-17 12:27 ` Kumar Gala
2014-10-20 11:34 ` Jingchang Lu
2014-10-19 2:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019013701.GC7869@tiger \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).