linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: serial: omap: increase max consoles to 10
Date: Wed, 22 Oct 2014 07:24:37 -0500	[thread overview]
Message-ID: <20141022122437.GA9548@kahuna> (raw)
In-Reply-To: <544764D8.8050804@linutronix.de>

On 10:03-20141022, Sebastian Andrzej Siewior wrote:
> On 10/21/2014 06:23 PM, Nishanth Menon wrote:
> > 
> > The final solution is to transition off to use 8250 driver and no
> > dependency on console structures and move away from omap-serial driver,
> > hence no major cleanups are done for this driver.
> 
> So the shiny new driver works for you, is this what you are saying?

We have to complete our transition over to the new driver to see if we
have any behavior change. We will eventually get there.

> 
> > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> > index 18c30ca..4f9cbb6 100644
> > --- a/drivers/tty/serial/omap-serial.c
> > +++ b/drivers/tty/serial/omap-serial.c
> > @@ -46,7 +46,7 @@
> >  
> >  #include <dt-bindings/gpio/gpio.h>
> >  
> > -#define OMAP_MAX_HSUART_PORTS	6
> > +#define OMAP_MAX_HSUART_PORTS	10
> >  
> >  #define UART_BUILD_REVISION(x, y)	(((x) << 8) | (y))
> 
> Please also add a check in the probe code that "up->port.line" does not
> exceed OMAP_MAX_HSUART_PORTS again. So we leave the probe function with
> an error code instead.

Thanks. yeah - that is a pretty good idea. Will do the same for v2.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2014-10-22 12:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 16:23 [PATCH] tty: serial: omap: increase max consoles to 10 Nishanth Menon
2014-10-22  8:03 ` Sebastian Andrzej Siewior
2014-10-22 12:24   ` Nishanth Menon [this message]
2014-10-22 12:46 ` [PATCH V2] tty: serial: omap: Increase max consoles and add check to prevent crash Nishanth Menon
2014-10-23 10:16   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022122437.GA9548@kahuna \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).