From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: mvebu: Move SCU power up in a function
Date: Fri, 24 Oct 2014 14:05:51 +0200 [thread overview]
Message-ID: <20141024140551.0890f204@free-electrons.com> (raw)
In-Reply-To: <1414088070-12510-3-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Thu, 23 Oct 2014 20:14:28 +0200, Gregory CLEMENT wrote:
> +ENTRY(power_up_scu)
> + mrc p15, 4, r1, c15, c0 @ get SCU base address
> + orr r1, r1, #0x8 @ SCU CPU Power Status Register
> + mrc 15, 0, r0, cr0, cr0, 5 @ get the CPU ID
> + and r0, r0, #15
> + add r1, r1, r0
> + mov r0, #0x0
> + strb r0, [r1] @ switch SCU power state to Normal mode
> + ret lr
> +ENDPROC(power_up_scu)
Since this function is not static, I think it might be a good idea to
use a prefix that makes it more specific to the platform in order to
not pollute the global namespace. Maybe something like
'armada_38x_scu_power_up', or something like that.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-24 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 18:14 [PATCH 0/4] Hot plug support for Armada 38x Gregory CLEMENT
2014-10-23 18:14 ` [PATCH 1/4] ARM: mvebu: Clean-up the Armada XP support Gregory CLEMENT
2014-10-23 18:41 ` Thomas Petazzoni
2014-10-23 18:14 ` [PATCH 2/4] ARM: mvebu: Move SCU power up in a function Gregory CLEMENT
2014-10-24 12:05 ` Thomas Petazzoni [this message]
2014-10-24 12:11 ` Gregory CLEMENT
2014-10-24 12:19 ` Thomas Petazzoni
2014-10-24 12:28 ` Gregory CLEMENT
2014-10-23 18:14 ` [PATCH 3/4] ARM: mvebu: Fix secondary startup for Cortex A9 SoC Gregory CLEMENT
2014-10-23 18:14 ` [PATCH 4/4] ARM: mvebu: Implement CPU hotplug support for Armada 38x Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024140551.0890f204@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).