* [PATCH] bcm2835: add VideoCore Mailbox to the device tree
@ 2014-10-24 13:20 Lubomir Rintel
2014-10-24 15:53 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Lubomir Rintel @ 2014-10-24 13:20 UTC (permalink / raw)
To: linux-arm-kernel
Follows the generic Mailbox Controller bindings as documented in
Documentation/devicetree/bindings/mailbox/mailbox.txt.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: devicetree at vger.kernel.org
Cc: linux-rpi-kernel at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
---
arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..bd046a9 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -50,6 +50,13 @@
#interrupt-cells = <2>;
};
+ mailbox: mailbox at 0x7e00b880 {
+ compatible = "brcm,bcm2835-mbox";
+ reg = <0x7e00b880 0x40>;
+ interrupts = <0 1>;
+ #mbox-cells = <1>;
+ };
+
watchdog at 7e100000 {
compatible = "brcm,bcm2835-pm-wdt";
reg = <0x7e100000 0x28>;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] bcm2835: add VideoCore Mailbox to the device tree
2014-10-24 13:20 [PATCH] bcm2835: add VideoCore Mailbox to the device tree Lubomir Rintel
@ 2014-10-24 15:53 ` Lee Jones
2014-10-26 2:52 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2014-10-24 15:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 24 Oct 2014, Lubomir Rintel wrote:
> Follows the generic Mailbox Controller bindings as documented in
> Documentation/devicetree/bindings/mailbox/mailbox.txt.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: devicetree at vger.kernel.org
> Cc: linux-rpi-kernel at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index 3342cb1..bd046a9 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -50,6 +50,13 @@
> #interrupt-cells = <2>;
> };
>
> + mailbox: mailbox at 0x7e00b880 {
Remove the 0x.
> + compatible = "brcm,bcm2835-mbox";
> + reg = <0x7e00b880 0x40>;
> + interrupts = <0 1>;
2 interrupts one cell right? No flags?
> + #mbox-cells = <1>;
> + };
> +
> watchdog at 7e100000 {
> compatible = "brcm,bcm2835-pm-wdt";
> reg = <0x7e100000 0x28>;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] bcm2835: add VideoCore Mailbox to the device tree
2014-10-24 15:53 ` Lee Jones
@ 2014-10-26 2:52 ` Stephen Warren
2014-10-26 15:22 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2014-10-26 2:52 UTC (permalink / raw)
To: linux-arm-kernel
On 10/24/2014 09:53 AM, Lee Jones wrote:
> On Fri, 24 Oct 2014, Lubomir Rintel wrote:
>
>> Follows the generic Mailbox Controller bindings as documented in
>> Documentation/devicetree/bindings/mailbox/mailbox.txt.
>>
>> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>> Cc: Stephen Warren <swarren@wwwdotorg.org>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: devicetree at vger.kernel.org
>> Cc: linux-rpi-kernel at lists.infradead.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>> arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index 3342cb1..bd046a9 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -50,6 +50,13 @@
>> #interrupt-cells = <2>;
>> };
>>
>> + mailbox: mailbox at 0x7e00b880 {
>
> Remove the 0x.
>
>> + compatible = "brcm,bcm2835-mbox";
>> + reg = <0x7e00b880 0x40>;
>> + interrupts = <0 1>;
>
> 2 interrupts one cell right? No flags?
The DT binding says 1 IRQ in the list, and the interrupt controller in
bcm2835.dtsi has 2 cells per IRQ.
Whether that's all the IRQs the HW has for this HW module, I don't know.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] bcm2835: add VideoCore Mailbox to the device tree
2014-10-26 2:52 ` Stephen Warren
@ 2014-10-26 15:22 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-10-26 15:22 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 25 Oct 2014, Stephen Warren wrote:
> On 10/24/2014 09:53 AM, Lee Jones wrote:
> > On Fri, 24 Oct 2014, Lubomir Rintel wrote:
> >
> >> Follows the generic Mailbox Controller bindings as documented in
> >> Documentation/devicetree/bindings/mailbox/mailbox.txt.
> >>
> >> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> >> Cc: Stephen Warren <swarren@wwwdotorg.org>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Cc: devicetree at vger.kernel.org
> >> Cc: linux-rpi-kernel at lists.infradead.org
> >> Cc: linux-arm-kernel at lists.infradead.org
> >> ---
> >> arch/arm/boot/dts/bcm2835.dtsi | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> >> index 3342cb1..bd046a9 100644
> >> --- a/arch/arm/boot/dts/bcm2835.dtsi
> >> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> >> @@ -50,6 +50,13 @@
> >> #interrupt-cells = <2>;
> >> };
> >>
> >> + mailbox: mailbox at 0x7e00b880 {
> >
> > Remove the 0x.
> >
> >> + compatible = "brcm,bcm2835-mbox";
> >> + reg = <0x7e00b880 0x40>;
> >> + interrupts = <0 1>;
> >
> > 2 interrupts one cell right? No flags?
>
> The DT binding says 1 IRQ in the list, and the interrupt controller in
> bcm2835.dtsi has 2 cells per IRQ.
>
> Whether that's all the IRQs the HW has for this HW module, I don't know.
Okay, so guessing <BANK INT> then. Very well, thanks for answering.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-26 15:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 13:20 [PATCH] bcm2835: add VideoCore Mailbox to the device tree Lubomir Rintel
2014-10-24 15:53 ` Lee Jones
2014-10-26 2:52 ` Stephen Warren
2014-10-26 15:22 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).