From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/5] arm64: Add AArch32 instruction set condition code checks
Date: Wed, 29 Oct 2014 15:21:48 +0000 [thread overview]
Message-ID: <20141029152148.GM27405@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1414435207-30240-4-git-send-email-punit.agrawal@arm.com>
On Mon, Oct 27, 2014 at 06:40:04PM +0000, Punit Agrawal wrote:
> arm64-obj-$(CONFIG_COMPAT) += sys32.o kuser32.o signal32.o \
> - sys_compat.o
> + sys_compat.o \
> + $(addprefix ../../arm/kernel/, \
> + opcodes.o)
This is not particularly nice. While it means that this file gets built
on both arm64 and arm, it means that it routinely won't get tested on
arm64 when changes to it happen.
The second reason it's not nice is that the whole $(addprefix thing
really isn't needed. You're only adding the prefix to one name. So,
a simpler way to write it is "../../arm/kernel/opcodes.o".
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-10-29 15:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 18:40 [PATCHv3 0/5] Legacy instruction emulation for arm64 Punit Agrawal
2014-10-27 18:40 ` [PATCHv3 1/5] arm64: Add support for hooks to handle undefined instructions Punit Agrawal
2014-11-05 11:27 ` Catalin Marinas
2014-11-06 12:20 ` Punit Agrawal
2014-10-27 18:40 ` Punit Agrawal
2014-10-29 14:26 ` Punit Agrawal
2014-10-27 18:40 ` [PATCHv3 2/5] arm64: Add AArch32 instruction set condition code checks Punit Agrawal
2014-10-29 15:21 ` Russell King - ARM Linux [this message]
2014-10-29 16:54 ` Punit Agrawal
2014-11-05 16:14 ` Catalin Marinas
2014-11-05 16:19 ` Will Deacon
2014-11-05 11:28 ` Catalin Marinas
2014-10-27 18:40 ` [PATCHv3 3/5] arm64: Port SWP/SWPB emulation support from arm Punit Agrawal
2014-11-05 11:47 ` Catalin Marinas
2014-11-07 18:15 ` Punit Agrawal
2014-10-27 18:40 ` [PATCHv3 4/5] arm64: Emulate CP15 Barrier instructions Punit Agrawal
2014-11-05 13:05 ` Catalin Marinas
2014-11-07 16:07 ` Punit Agrawal
2014-11-13 10:34 ` Catalin Marinas
2014-11-05 14:51 ` Catalin Marinas
2014-11-07 13:03 ` Punit Agrawal
2014-10-27 18:40 ` [PATCHv3 5/5] arm64: Trace emulation of AArch32 legacy instructions Punit Agrawal
2014-11-05 14:46 ` Catalin Marinas
2014-11-05 15:05 ` Steven Rostedt
2014-11-05 15:52 ` Catalin Marinas
2014-11-10 18:27 ` Will Deacon
2014-11-12 11:31 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029152148.GM27405@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).