From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 30 Oct 2014 17:40:15 +0100 Subject: [PATCH 1/5] phy: sun4i: add support for USB phy0 In-Reply-To: References: <668c1b5541fc0175957573bd5f8d40dd2eaccae1.1414444953.git.rbyshko@gmail.com> <20141028214756.GF9255@lukather> Message-ID: <20141030164015.GN21251@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Oct 29, 2014 at 10:24:12AM +0800, Chen-Yu Tsai wrote: > On Wed, Oct 29, 2014 at 5:47 AM, Maxime Ripard > wrote: > > Hi Roman, > > > > Thanks for your patches > > > > On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: > >> The driver for sun4i USB phys currently supports > >> only phy1 and phy2 which are used for USB host > >> controllers. This patch adds support for USB phy0, > >> which is used by the musb hdrc USB controller. > > > > Like Andreas already pointed out, your signed-off-by is missing from > > all your patches. > > > >> --- > >> drivers/phy/phy-sun4i-usb.c | 9 ++++++--- > >> 1 file changed, 6 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c > >> index 0baf5ef..a24728b 100644 > >> --- a/drivers/phy/phy-sun4i-usb.c > >> +++ b/drivers/phy/phy-sun4i-usb.c > >> @@ -157,6 +157,10 @@ static int sun4i_usb_phy_init(struct phy *_phy) > >> return ret; > >> } > >> > >> + /* Regulation 45 ohms */ > >> + if (phy->index == 0) > >> + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1); > > > > What is this code supposed to do? > > > > Some define for this bit and/or a better comment would be nice. > > From Allwinner's sources: "Enable/Disable USB res45 Calibration" > > which I think refers to the internal 45 ohm termination resistors > for the USB data lines. But I'm not an expert on USB hardware. That would make a great comment ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: