* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
[not found] <20141030165434.GW20170@rric.localhost>
@ 2014-10-31 2:45 ` Stephen Hemminger
2014-10-31 16:17 ` Robert Richter
2014-10-31 2:54 ` Stephen Hemminger
1 sibling, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2014-10-31 2:45 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 30 Oct 2014 17:54:34 +0100
Robert Richter <rric@kernel.org> wrote:
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1fa99a301817..80bd3336691e 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2324,6 +2324,8 @@
> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea
> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb
>
> +#define PCI_VENDOR_ID_CAVIUM 0x177d
I don't think PCI folks want this updated with every id anymore.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
[not found] <20141030165434.GW20170@rric.localhost>
2014-10-31 2:45 ` [PATCH] VNIC: Adding support for Cavium ThunderX network controller Stephen Hemminger
@ 2014-10-31 2:54 ` Stephen Hemminger
2014-10-31 17:14 ` Sunil Kovvuri
1 sibling, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2014-10-31 2:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 30 Oct 2014 17:54:34 +0100
Robert Richter <rric@kernel.org> wrote:
> +#ifdef VNIC_RSS_SUPPORT
> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> +module_param(rss_config, int, S_IRUGO);
> +MODULE_PARM_DESC(rss_config,
> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> +#endif
This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
2014-10-31 2:45 ` [PATCH] VNIC: Adding support for Cavium ThunderX network controller Stephen Hemminger
@ 2014-10-31 16:17 ` Robert Richter
0 siblings, 0 replies; 7+ messages in thread
From: Robert Richter @ 2014-10-31 16:17 UTC (permalink / raw)
To: linux-arm-kernel
On 30.10.14 19:45:13, Stephen Hemminger wrote:
> On Thu, 30 Oct 2014 17:54:34 +0100
> Robert Richter <rric@kernel.org> wrote:
>
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 1fa99a301817..80bd3336691e 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2324,6 +2324,8 @@
> > #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea
> > #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb
> >
> > +#define PCI_VENDOR_ID_CAVIUM 0x177d
>
> I don't think PCI folks want this updated with every id anymore.
This is just the vendor id, the device id is part of the driver.
Since there will be multiple drivers I put the vendor id here.
-Robert
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
2014-10-31 2:54 ` Stephen Hemminger
@ 2014-10-31 17:14 ` Sunil Kovvuri
2014-11-03 18:16 ` Stephen Hemminger
0 siblings, 1 reply; 7+ messages in thread
From: Sunil Kovvuri @ 2014-10-31 17:14 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Thu, 30 Oct 2014 17:54:34 +0100
> Robert Richter <rric@kernel.org> wrote:
>
>> +#ifdef VNIC_RSS_SUPPORT
>> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
>> +module_param(rss_config, int, S_IRUGO);
>> +MODULE_PARM_DESC(rss_config,
>> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
>> +#endif
>
> This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
The idea here is to have a choice of hash while module load (through
module params) and if it needs to be changed runtime then
via Ethtool.
Sunil.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
2014-10-31 17:14 ` Sunil Kovvuri
@ 2014-11-03 18:16 ` Stephen Hemminger
2014-11-03 18:33 ` Robert Richter
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2014-11-03 18:16 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 31 Oct 2014 22:44:11 +0530
Sunil Kovvuri <sunil.kovvuri@gmail.com> wrote:
> On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Thu, 30 Oct 2014 17:54:34 +0100
> > Robert Richter <rric@kernel.org> wrote:
> >
> >> +#ifdef VNIC_RSS_SUPPORT
> >> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> >> +module_param(rss_config, int, S_IRUGO);
> >> +MODULE_PARM_DESC(rss_config,
> >> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> >> +#endif
> >
> > This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
> Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
> The idea here is to have a choice of hash while module load (through
> module params) and if it needs to be changed runtime then
> via Ethtool.
>
> Sunil.
Network developers do not like vendor unique module parameters.
Anything device specific doesn't work in a generic distro environment.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
2014-11-03 18:16 ` Stephen Hemminger
@ 2014-11-03 18:33 ` Robert Richter
2014-11-03 20:25 ` Stephen Hemminger
0 siblings, 1 reply; 7+ messages in thread
From: Robert Richter @ 2014-11-03 18:33 UTC (permalink / raw)
To: linux-arm-kernel
On 03.11.14 10:16:51, Stephen Hemminger wrote:
> On Fri, 31 Oct 2014 22:44:11 +0530
> Sunil Kovvuri <sunil.kovvuri@gmail.com> wrote:
>
> > On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > > On Thu, 30 Oct 2014 17:54:34 +0100
> > > Robert Richter <rric@kernel.org> wrote:
> > >
> > >> +#ifdef VNIC_RSS_SUPPORT
> > >> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> > >> +module_param(rss_config, int, S_IRUGO);
> > >> +MODULE_PARM_DESC(rss_config,
> > >> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> > >> +#endif
> > >
> > > This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
> > Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
> > The idea here is to have a choice of hash while module load (through
> > module params) and if it needs to be changed runtime then
> > via Ethtool.
> >
> > Sunil.
>
> Network developers do not like vendor unique module parameters.
> Anything device specific doesn't work in a generic distro environment.
Do you accept unique module parameters in parallel to ethtool support
or should this be removed?
-Robert
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] VNIC: Adding support for Cavium ThunderX network controller
2014-11-03 18:33 ` Robert Richter
@ 2014-11-03 20:25 ` Stephen Hemminger
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2014-11-03 20:25 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 3 Nov 2014 19:33:45 +0100
Robert Richter <robert.richter@caviumnetworks.com> wrote:
> On 03.11.14 10:16:51, Stephen Hemminger wrote:
> > On Fri, 31 Oct 2014 22:44:11 +0530
> > Sunil Kovvuri <sunil.kovvuri@gmail.com> wrote:
> >
> > > On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
> > > <stephen@networkplumber.org> wrote:
> > > > On Thu, 30 Oct 2014 17:54:34 +0100
> > > > Robert Richter <rric@kernel.org> wrote:
> > > >
> > > >> +#ifdef VNIC_RSS_SUPPORT
> > > >> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> > > >> +module_param(rss_config, int, S_IRUGO);
> > > >> +MODULE_PARM_DESC(rss_config,
> > > >> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> > > >> +#endif
> > > >
> > > > This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
> > > Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
> > > The idea here is to have a choice of hash while module load (through
> > > module params) and if it needs to be changed runtime then
> > > via Ethtool.
> > >
> > > Sunil.
> >
> > Network developers do not like vendor unique module parameters.
> > Anything device specific doesn't work in a generic distro environment.
>
> Do you accept unique module parameters in parallel to ethtool support
> or should this be removed?
If there is ethtool support the module parameters are not needed.
Unneeded code is to be avoided.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-03 20:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20141030165434.GW20170@rric.localhost>
2014-10-31 2:45 ` [PATCH] VNIC: Adding support for Cavium ThunderX network controller Stephen Hemminger
2014-10-31 16:17 ` Robert Richter
2014-10-31 2:54 ` Stephen Hemminger
2014-10-31 17:14 ` Sunil Kovvuri
2014-11-03 18:16 ` Stephen Hemminger
2014-11-03 18:33 ` Robert Richter
2014-11-03 20:25 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).