[PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode

[tony@atomide.com (Tony Lindgren)]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [141031 12:32]:
> 
> Last night I tried enabling DT booting on the LDP.  This resulted in
> quite a horrid mess, so I don't think you're there still.

Thanks for trying. Other than the mystery battery issue, the others
should pretty much go away with just .config changes it seems.

> The biggest problem seems to be that the kernel does /nothing/ but
> spit out:
> 
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> power_supply twl4030_ac: driver failed to report `current_now' property: -850000
> twl4030_bci bci.7: battery disconnected
> twl4030_bci bci.7: battery disconnected
> 
> Yes, the battery is disconnected, but there's absolutely no reason to keep
> printing that damned warning time and time again.  The boot logger didn't
> expect this, and it's logged about 16 hours of these continual messages
> into the database... that's around 1.4GB of log!

Hmm, I thought Nishant fixed that already with commit 61a7784efd3
"power: twl4030_charger: detect battery presence prior to enabling
charger".

I'm not seeing these errors with twl4030_charger built in. For me it just
bails out without a battery like it should:

twl4030_bci 48070000.i2c:twl at 48:bci: Battery was not detected:-19

Nishant, any ideas on this one?
 
> Other errors:
> 
> omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp
> omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp

This is a known issue with data for multiple devices squashed
into one in the .dts files.

Peter, any news on fixing up this issue? I think you promised to
look at it already a while back :)

> WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2538 _init+0xc8/0x170()
> omap_hwmod: ssi: doesn't have mpu register target base
> ...

Not seeing this one, is this maybe from the legacy mode boot?

> omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
> omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm

Not seeing these either. Is this maybe from your 4430sdp instead?

> omap_hwmod: mcbsp2: cannot be enabled for reset (3)

This I'm seeing too, will take a look at this one.

> twl4030_keypad keypad.31: OF: linux,keymap property not defined in /ocp/i2c at 48070000/twl at 48/keypad
> twl4030_keypad keypad.31: Failed to build keymap
> twl4030_keypad: probe of keypad.31 failed with error -2

I'll take a look at this one as we now have a binding for
twl4030_keypad. Probably just missing the keymap in the .dts
file. The gpio keys should work though.
 
> Digging the remaining messages out from between all the crap about the
> battery:
> 
> 4809c000.mmc supply vmmc_aux not found, using dummy regulator
> omap_hsmmc 4809c000.mmc: pins are not configured from the driver
> 4809c000.mmc supply card-external-vcc not found, using dummy regulator
> 480b4000.mmc supply vmmc not found, using dummy regulator
> 480b4000.mmc supply vmmc_aux not found, using dummy regulator
> omap_hsmmc 480b4000.mmc: pins are not configured from the driver
> mmc0: host does not support reading read-only switch. assuming write-enable.
> 480b4000.mmc supply card-external-vcc not found, using dummy regulator

Not seeing this with my LDP. I think you're probably missing:
CONFIG_REGULATOR_TWL4030
CONFIG_REGULATOR_PBIAS

> mmc0: new high speed SD card at address 0002
> mmcblk0: mmc0:0002 00000 971 MiB
> omap_hsmmc 480b4000.mmc: could not set regulator OCR (-22)
> 480ad000.mmc supply vmmc not found, using dummy regulator
> 480ad000.mmc supply vmmc_aux not found, using dummy regulator
> omap_hsmmc 480ad000.mmc: could not set regulator OCR (-22)
>  mmcblk0: p1 p2
> omap_hsmmc 480ad000.mmc: pins are not configured from the driver
> mmcblk0: error -84 transferring data, sector 1473761, nr 32, cmd response 0x900, card status 0xb00
> mmcblk0: retrying using single block read
> mmcblk0: error -84 transferring data, sector 426249, nr 32, cmd response 0x900, card status 0xb00
> mmcblk0: retrying using single block read
> mmcblk0: error -84 transferring data, sector 1525321, nr 192, cmd response 0x900, card status 0xb00
> mmcblk0: retrying using single block read
> ... etc ...

I'm not seeing this one either on my LDP. I'm getting just one warning
"multiblock reads disabled due to 35xx erratum 2.1.1.128"
but the card works just fine here with no errors. I'd assume these go
away with enabling the regulators above.
 
> Of course, no problems with exactly the same kernel binary image without
> DT.  I'd summarise this as DT remains totally unusable on LDP3430.  It's
> soo unusable that it is going to /force/ me to take it out of the nightly
> boot test, otherwise I'm going to have to manually intervene each and
> every morning to kill the board.

The LDP is certainly usable here with device tree based booting.

It seems you're probably missing some .config options. Care to post
your .config somewhere? Or maybe give it a try with omap2plus_defconfig?

If that works, then maybe enable CONFIG_CHARGER_TWL4030=y in
omap2plus_defconfig and see if you get the battery issue with it too?

Regards,

Tony