From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: imx: clk-vf610: define PLL's clock tree
Date: Mon, 3 Nov 2014 11:39:08 +0800 [thread overview]
Message-ID: <20141103033907.GB10821@tiger> (raw)
In-Reply-To: <1414428044-22103-1-git-send-email-stefan@agner.ch>
On Mon, Oct 27, 2014 at 05:40:44PM +0100, Stefan Agner wrote:
> So far, the required PLL's (PLL1/PLL2/PLL5) have been initialized
> by boot loader and the kernel code defined fixed rates according
> to those default configurations. Beginning with the USB PLL7 the
> code started to initialize the PLL's itself (using imx_clk_pllv3).
>
> However, since commit dc4805c2e78ba5a22ea1632f3e3e4ee601a1743b
> (ARM: imx: remove ENABLE and BYPASS bits from clk-pllv3 driver)
> imx_clk_pllv3 no longer takes care of the ENABLE and BYPASS bits,
> hence the USB PLL were not configured correctly anymore.
Sorry for that.
>
> This patch not only fixes those USB PLL's, but also makes use of
> the imx_clk_pllv3 for all PLL's and alignes the code with the PLL
> support of the i.MX6 series.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Shawn, I sent this almost 1 month ago, along with a mail asking
> of the state a week ago. But both to your old e-mail, I guess you
> didn't received it then...?
> Also some other Vybrid related patches,
> shall I resend them with your new e-mail?
Yes, resending them helps.
>
> If possible, it still would be great if this makes it into 3.18.
> Right now, because of the clk-pllv3 change, the newly added USB
> support is broken...
>
> I could have created a patch which only fixes the USB PLL7, but
> then we touch the header file twice and its getting a mess in
> there. I prefer to have it fixed once for all PLL's. I hope this
> makes it into 3.18 nonetheless. If not, I'm also fine if this
> makes it into next.
The diff looks a little bit big, but it does fix a regression, so let
me try to send it for 3.18.
Thanks for the fixing.
Shawn
>
> arch/arm/mach-imx/clk-vf610.c | 134 ++++++++++++++++++++++----------
> include/dt-bindings/clock/vf610-clock.h | 39 ++++++++--
> 2 files changed, 123 insertions(+), 50 deletions(-)
prev parent reply other threads:[~2014-11-03 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 16:40 [PATCH RESEND] ARM: imx: clk-vf610: define PLL's clock tree Stefan Agner
2014-11-03 3:39 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103033907.GB10821@tiger \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox