From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons
Date: Mon, 3 Nov 2014 14:21:15 +0800 [thread overview]
Message-ID: <20141103062114.GE10821@tiger> (raw)
In-Reply-To: <1414614311-2199-1-git-send-email-festevam@gmail.com>
On Wed, Oct 29, 2014 at 06:25:11PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Allow the two button wakeup the system from low power mode.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/boot/dts/imx6sx-sdb.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
> index 448489b..80ae281 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> @@ -39,12 +39,14 @@
> volume-up {
> label = "Volume Up";
> gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
> + gpio-key,wakeup;
I can understand that this is convenient for developers, but I'm not
really sure if it's reasonable for users. IOW, is it expected that
volume keys can wake up system from low power mode? Or we should only
allow that from power key?
Shawn
> linux,code = <KEY_VOLUMEUP>;
> };
>
> volume-down {
> label = "Volume Down";
> gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
> + gpio-key,wakeup;
> linux,code = <KEY_VOLUMEDOWN>;
> };
> };
> --
> 1.9.1
>
prev parent reply other threads:[~2014-11-03 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 20:25 [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons Fabio Estevam
2014-11-03 6:21 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103062114.GE10821@tiger \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).