From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: db8500-prcmu: Provide sane error path values
Date: Mon, 3 Nov 2014 16:50:35 +0000 [thread overview]
Message-ID: <20141103165035.GB12011@x1> (raw)
In-Reply-To: <CAOMZO5C2sB1GNuNE-Bi5jqMO4DqBcDW2C1O+asYkbW=8fXA7TA@mail.gmail.com>
On Mon, 03 Nov 2014, Fabio Estevam wrote:
> On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > /* Clean up the mailbox interrupts after pre-kernel code. */
> > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
> > irq = platform_get_irq(pdev, 0);
> > if (irq <= 0) {
>
> Shouldn't this be if (irq < 0) then?
Perhaps Linus can answer that.
Linus,
Is 0 a valid IRQ on the u8500 platform or not?
> > dev_err(&pdev->dev, "no prcmu irq provided\n");
> > - return -ENOENT;
> > + return irq;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-03 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:15 [PATCH] mfd: db8500-prcmu: Provide sane error path values Lee Jones
2014-11-03 16:35 ` Fabio Estevam
2014-11-03 16:50 ` Lee Jones [this message]
2014-11-04 10:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103165035.GB12011@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).