From mboxrd@z Thu Jan  1 00:00:00 1970
From: lee.jones@linaro.org (Lee Jones)
Date: Mon, 3 Nov 2014 16:50:35 +0000
Subject: [PATCH] mfd: db8500-prcmu: Provide sane error path values
In-Reply-To: <CAOMZO5C2sB1GNuNE-Bi5jqMO4DqBcDW2C1O+asYkbW=8fXA7TA@mail.gmail.com>
References: <1415031356-11664-1-git-send-email-lee.jones@linaro.org>
 <CAOMZO5C2sB1GNuNE-Bi5jqMO4DqBcDW2C1O+asYkbW=8fXA7TA@mail.gmail.com>
Message-ID: <20141103165035.GB12011@x1>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, 03 Nov 2014, Fabio Estevam wrote:

> On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones <lee.jones@linaro.org> wrote:
> 
> >         /* Clean up the mailbox interrupts after pre-kernel code. */
> > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
> >         irq = platform_get_irq(pdev, 0);
> >         if (irq <= 0) {
> 
> Shouldn't this be if (irq < 0) then?

Perhaps Linus can answer that.

Linus,

  Is 0 a valid IRQ on the u8500 platform or not?

> >                 dev_err(&pdev->dev, "no prcmu irq provided\n");
> > -               return -ENOENT;
> > +               return irq;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog