linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] mfd: ab8500: Decrement the power supply's device reference counter
Date: Mon, 3 Nov 2014 18:00:59 +0000	[thread overview]
Message-ID: <20141103180059.GW12011@x1> (raw)
In-Reply-To: <20141103175945.GV12011@x1>

On Mon, 03 Nov 2014, Lee Jones wrote:

> On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:
> 
> > Use power_supply_put() to decrement the power supply's device reference
> > counter.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  drivers/mfd/ab8500-sysctrl.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Applied, thanks.

Whoops, to hasty there -- unapplied.

What's going on with this set?

> > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
> > index 93b2d2c32ca3..d05a5719cfc4 100644
> > --- a/drivers/mfd/ab8500-sysctrl.c
> > +++ b/drivers/mfd/ab8500-sysctrl.c
> > @@ -51,6 +51,7 @@ static void ab8500_power_off(void)
> >  
> >  		ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE,
> >  				&val);
> > +		power_supply_put(psy);
> >  
> >  		if (!ret && val.intval) {
> >  			charger_present = true;
> > @@ -73,6 +74,7 @@ static void ab8500_power_off(void)
> >  			       pss[i]);
> >  			machine_restart("charging");
> >  		}
> > +		power_supply_put(psy);
> >  	}
> >  
> >  shutdown:
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-11-03 18:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 12:35 [PATCH 0/7] power_supply: Decrement the device reference counter Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 1/7] power_supply: Add power_supply_put for decrementing " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 2/7] power: charger-manager: Decrement the power supply's " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 3/7] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 4/7] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 5/7] power: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 6/7] power: bq2415x_charger: " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 7/7] mfd: ab8500: " Krzysztof Kozlowski
2014-10-28 10:00   ` Linus Walleij
2014-11-03 17:59   ` Lee Jones
2014-11-03 18:00     ` Lee Jones [this message]
2014-11-04  7:50       ` Krzysztof Kozlowski
2014-10-15 12:18 ` [PATCH 0/7] power_supply: Decrement the " Pavel Machek
2014-10-15 12:52   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141103180059.GW12011@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).