linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: imx: Fix the removal of CONFIG_SPI option
Date: Tue, 4 Nov 2014 16:26:46 +0100	[thread overview]
Message-ID: <20141104152646.GA8450@pengutronix.de> (raw)
In-Reply-To: <1415096927-4097-1-git-send-email-festevam@gmail.com>

[Note, this is a resend of a mail I accidently only sent to Fabio 
before.]

Hello,

On Tue, Nov 04, 2014 at 08:28:47AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since 64546e9fe3a5b8c ("ARM: imx_v6_v7_defconfig updates") and commit 
> 0650f855d2e4b0b9 ("ARM: imx_v4_v5_defconfig: Select CONFIG_IMX_WEIM") CONFIG_SPI
> selection was dropped by savedefconfig for imx_v4_v5_defconfig and 
> imx_v6_v7_defconfig.
> 
> In order to keep the same behaviour as previous kernel versions and avoid 
> regressions, let's add CONFIG_SPI option back.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Add commit id's that caused the issue.
on top of 64546e9fe3a5b8c doing

        make imx_v6_v7_defconfig

resulted in CONFIG_SPI=y. That's because MEDIA_SUBDRV_AUTOSELECT selects
SPI and has default y.

So the commit that really broke imx_v6_v7_defconfig is 7d24c514e8e0
([media] Kconfig: do not select SPI bus on sub-driver auto-select).
On a side note I wonder how that commit sneaked into v3.17-rc6.

I think people need to be more aware of the results of Kconfig changes
...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2014-11-04 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 10:28 [PATCH v2] ARM: imx: Fix the removal of CONFIG_SPI option Fabio Estevam
2014-11-04 11:07 ` Shawn Guo
2014-11-04 15:05   ` Fabio Estevam
2014-11-04 15:26 ` Uwe Kleine-König [this message]
2014-11-04 15:55   ` Antti Palosaari
2014-11-04 19:18     ` Uwe Kleine-König
2014-11-04 19:26       ` Antti Palosaari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141104152646.GA8450@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).