From: voytikd@gmail.com (Dmitry Voytik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: refactor mxc_iomux_mode()
Date: Thu, 6 Nov 2014 22:36:39 +0400 [thread overview]
Message-ID: <20141106183639.GA17308@ubuntuvm> (raw)
In-Reply-To: <54dc2a9edf554125b2158a1f9edd8adb@BN1PR0301MB0772.namprd03.prod.outlook.com>
Hi Peter,
On Tue, Nov 04, 2014 at 12:21:55PM +0000, Peter Chen wrote:
> > > -int mxc_iomux_mode(unsigned int pin_mode)
> > > +void mxc_iomux_mode(unsigned int pin_mode)
> > > {
> > > - u32 field, l, mode, ret = 0;
> > > + u32 field;
> > > + u32 l;
> > > + u32 mode;
> > > void __iomem *reg;
> > >
>
> Why you use three lines to define it, it makes the function longer.
You're right but there is a recommendation in coding style to declare
variables on separate lines (see Documentation/CodingStyle,
line 469), which improves readability, imho. By the way I saw many
times, that maintainers asked to declare variables separately.
> Besides, Shawn's email changes to : <shawn.guo@linaro.org>
Oops, didn't see that. Thanks!
WBR.
next prev parent reply other threads:[~2014-11-06 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 14:35 [PATCH] ARM: imx: refactor mxc_iomux_mode() Dmitry Voytik
2014-10-27 14:20 ` Dmitry Voytik
2014-11-04 12:21 ` Peter Chen
2014-11-06 18:36 ` Dmitry Voytik [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-06 18:55 Dmitry Voytik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106183639.GA17308@ubuntuvm \
--to=voytikd@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).