linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: gadget: udc: pxa27x: fix build warning when !OF
Date: Thu, 6 Nov 2014 16:25:07 -0600	[thread overview]
Message-ID: <20141106222507.GE27324@saruman> (raw)
In-Reply-To: <20141106221748.GD27324@saruman>

On Thu, Nov 06, 2014 at 04:17:48PM -0600, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Nov 06, 2014 at 08:55:35PM +0100, Robert Jarzmik wrote:
> > Daniel Mack <daniel@zonque.org> writes:
> > 
> > > On 11/06/2014 05:55 AM, Felipe Balbi wrote:
> > >> in case kernel is built without CONFIG_OF there
> > >> will be a build warning (see below) due to of_match_ptr()
> > >> being defined to NULL.
> > >> 
> > >> Because of_match_ptr() is pretty pointless anyway,
> > >> let's just remove it and fix the warning.
> > >
> > > The alternative, of course, would be to wrap the udc_pxa_dt_ids
> > > declaration in IS_ENABLED(CONFIG_OF), but I'm not sure whether it's
> > > worth it.
> > 
> > Ah, wasn't the patch named "[PATCH v1] usb: gadget: pxa27x_udc: fix
> > warning in non device-tree build" sent October the 29th fixing this
> > issue (in [1]) ?
> 
> I seem to have missed that, let me replace the patches and use yours.

now done.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141106/3ff76046/attachment.sig>

  reply	other threads:[~2014-11-06 22:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  4:55 [PATCH] usb: gadget: udc: pxa27x: fix build warning when !OF Felipe Balbi
2014-11-06  6:47 ` Daniel Mack
2014-11-06 19:55   ` Robert Jarzmik
2014-11-06 22:17     ` Felipe Balbi
2014-11-06 22:25       ` Felipe Balbi [this message]
2014-11-07  7:26         ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141106222507.GE27324@saruman \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).