public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun6i: Re-parent ahb1_mux to pll6 as required by dma controller
Date: Sat, 8 Nov 2014 15:57:01 +0100	[thread overview]
Message-ID: <20141108145701.GZ2989@lukather> (raw)
In-Reply-To: <1415275009-415-1-git-send-email-wens@csie.org>

On Thu, Nov 06, 2014 at 07:56:49PM +0800, Chen-Yu Tsai wrote:
> The dma controller requires that the ahb1 bus clock be driven by pll6
> for peripheral access to work. Previously this was done in the dma
> controller driver, but was since removed as part of a series to unify
> the ahb1_mux and ahb1 clock drivers, in
> 
>     14e0e28 dmaengine: sun6i: Remove obsolete clk muxing code
> 
> Unfortunately the rest of that series did not make it, leaving us with
> broken dma on sun6i.
> 
> This patch reparents ahb1_mux to pll6 using the DT assigned-clocks
> properties in the dma controller node.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Hi Maxime,
> 
> This is for 3.18 to fix broken dma. I have verified the clock register
> bits on my A31 Hummingbird. Though I do not have actual hardware to test
> dma peripherals, since this does return things to the way they were, it
> is a proper fix.
> 
> Sorry for the breakage.

Tested and applied, thanks !

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141108/40831afa/attachment.sig>

      reply	other threads:[~2014-11-08 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 11:56 [PATCH] ARM: dts: sun6i: Re-parent ahb1_mux to pll6 as required by dma controller Chen-Yu Tsai
2014-11-08 14:57 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141108145701.GZ2989@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox