linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ptrace: add generic SET_SYSCALL request
Date: Wed, 12 Nov 2014 11:13:52 +0000	[thread overview]
Message-ID: <20141112111352.GC26437@arm.com> (raw)
In-Reply-To: <54633F53.8020507@linaro.org>

On Wed, Nov 12, 2014 at 11:06:59AM +0000, AKASHI Takahiro wrote:
> On 11/12/2014 08:00 PM, Will Deacon wrote:
> > On Wed, Nov 12, 2014 at 10:46:01AM +0000, AKASHI Takahiro wrote:
> >> On 11/07/2014 11:04 PM, Oleg Nesterov wrote:
> >>> To me the fact that PTRACE_SET_SYSCALL can be undefined and syscall_set_nr()
> >>> is very much arch-dependant (but most probably trivial) means that this  code
> >>> should live in arch_ptrace().
> >>
> >> Thinking of Oleg's comment above, it doesn't make sense neither to define generic
> >> NT_SYSTEM_CALL (user_regset) in uapi/linux/elf.h and implement it in ptrace_regset()
> >> in kernel/ptrace.c with arch-defined syscall_(g)set_nr().
> >>
> >> Since we should have the same interface on arm and arm64, we'd better implement
> >> ptrace(PTRACE_SET_SYSCALL) locally on arm64 for now (as I originally submitted).
> >
> > I think the regset approach is cleaner. We already do something similar for
> > TLS. That would be implemented under arch/arm64/ with it's own NT type.
> 
> Okey, so arm64 goes its own way :)
> Or do you want to have a similar regset on arm, too?
> (In this case, NT_ARM_SYSTEM_CALL can be shared in uapi/linux/elf.h)

Just do arm64. We already have the dedicated request for arch/arm/.

Will

  reply	other threads:[~2014-11-12 11:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  7:47 [RFC] ptrace: add generic SET_SYSCALL request AKASHI Takahiro
2014-11-07  9:30 ` Arnd Bergmann
2014-11-07 11:55   ` Will Deacon
2014-11-07 12:03     ` Arnd Bergmann
2014-11-07 12:11       ` Russell King - ARM Linux
2014-11-07 12:44         ` Arnd Bergmann
2014-11-07 13:11           ` Will Deacon
2014-11-07 14:30             ` Arnd Bergmann
2014-11-07 16:44               ` Kees Cook
2014-11-07 23:05                 ` Roland McGrath
2014-11-07 12:27       ` Will Deacon
2014-11-10  6:36         ` AKASHI Takahiro
2014-11-07 14:04 ` Oleg Nesterov
2014-11-12 10:46   ` AKASHI Takahiro
2014-11-12 11:00     ` Will Deacon
2014-11-12 11:06       ` AKASHI Takahiro
2014-11-12 11:13         ` Will Deacon [this message]
2014-11-12 11:19           ` Arnd Bergmann
2014-11-12 12:05             ` Russell King - ARM Linux
2014-11-13  7:02             ` AKASHI Takahiro
2014-11-13 10:21               ` Arnd Bergmann
2014-11-13 14:49                 ` Ulrich Weigand
2014-11-13 22:25                   ` Arnd Bergmann
2014-11-14  1:40                     ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141112111352.GC26437@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).