From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Thu, 13 Nov 2014 09:28:16 +0800 Subject: [PATCH] dma: imx-sdma: clarify about firmware not found error In-Reply-To: <1415829869-6661-1-git-send-email-festevam@gmail.com> References: <1415829869-6661-1-git-send-email-festevam@gmail.com> Message-ID: <20141113012814.GO2704@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 12, 2014 at 08:04:29PM -0200, Fabio Estevam wrote: > From: Sascha Hauer > > When a firmware cannot be found for the SDMA engine then we can > continue with the internal ROM firmware. > > The meaning of this message is frequently asked for, so make clear > that the driver still works with the internal ROM firmware and reduce > the loglevel from err to info. > > Cc: Vinod Koul > Cc: linux-arm-kernel at lists.infradead.org > Cc: Shawn Guo Acked-by: Shawn Guo > Signed-off-by: Sascha Hauer > Signed-off-by: Fabio Estevam > --- > drivers/dma/imx-sdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 99d8833..2c67da5 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context) > unsigned short *ram_code; > > if (!fw) { > - dev_err(sdma->dev, "firmware not found\n"); > + dev_info(sdma->dev, "external firmware not found, using ROM firmware\n"); > + /* In this case we just use the ROM firmware. */ > return; > } > > -- > 1.9.1 >