[linux-sunxi] Re: [PATCH 3/4] simplefb: Change simplefb_init from module_init to fs_initcall

Hans de Goede
2014-11-13T19:04:35Z

Hi,

On 11/13/2014 05:13 PM, Stefan Monnier wrote:
>> Like a lot of things, if it is made a modules, and it breaks for the
>> user, the user gets to keep the pieces. There are potentially some
>
> But the option's description should probably include some blurb about
> the fact that it only works as a module with some combinations of
> SoC+kernel.

So I was about to add an update of the Kconfig text along this line
while I was respinning the patch anyways, and guess what simplefb
currently cannot be build as a module, so this is a non-issue.

I'll update my "simplefb: Add support for enumerating simplefb dt nodes in /chosen"
patch to not have a module_exit in the next version, since that is
not really useful if it cannot be build as a module anyways.

Regards,

Hans