From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/13] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes
Date: Thu, 13 Nov 2014 10:22:18 +0000 [thread overview]
Message-ID: <20141113102218.GA25886@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <20141110101131.GP21424@x1>
Hi Lee,
Thanks for reviewing.
On Mon, 10 Nov 2014, Lee Jones wrote:
> > + reg = <0xf8 0x04>, /* syscfg 5062 */
> > + <0xf4 0x04>; /* syscfg 5061 */
>
> Are there really only 2 32bit registers to control this h/w?
Yes
>
> > + reg-names = "param",
> > + "ctrl";
>
> Superflous indentation after 'reg = ' and 'reg-names = '.
Fixed in v2.
> > + st,syscfg = <&syscfg_core>;
> > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> > + <&picophyreset STIH407_PICOPHY0_RESET>;
> > + reset-names = "global",
> > + "port";
>
> May as well put these on the same line.
Fixed in v2.
regards,
Peter.
next prev parent reply other threads:[~2014-11-13 10:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 11:57 [PATCH 00/13] Add stih410 SoC and USB2/1.1 support Peter Griffin
2014-11-07 11:57 ` [PATCH 01/13] ARM: STi: DT: STiH416: Add pinctl setup for usb controllers Peter Griffin
2014-11-10 10:50 ` Lee Jones
2014-11-07 11:57 ` [PATCH 02/13] ARM: STi: DT: STiH416: Add DT node for the stih415/6 usb2 phy Peter Griffin
2014-11-10 10:49 ` Lee Jones
2014-11-12 13:55 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 03/13] ARM: STi: DT: STiH416: Add DT nodes for the ehci and ohci usb controllers Peter Griffin
2014-11-07 12:08 ` Arnd Bergmann
2014-11-12 13:44 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 04/13] ARM: multi_v7_defconfig: Enable st ohci and ehci HCD drivers Peter Griffin
2014-11-10 10:48 ` Lee Jones
2014-11-07 11:57 ` [PATCH 05/13] ARM: multi_v7_defconfig: Enable stih415/6 usb2 phy driver Peter Griffin
2014-11-10 10:47 ` Lee Jones
2014-11-07 11:57 ` [PATCH 06/13] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
2014-11-10 10:28 ` Lee Jones
2014-11-07 11:57 ` [PATCH 07/13] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes Peter Griffin
2014-11-10 10:11 ` Lee Jones
2014-11-13 10:22 ` Peter Griffin [this message]
2014-11-07 11:57 ` [PATCH 08/13] ARM: STi: DT: STiH410: Add defines for STiH410 DT clocks Peter Griffin
2014-11-10 10:08 ` Lee Jones
2014-11-07 11:57 ` [PATCH 09/13] ARM: STi: DT: STiH410: Add pinctl config for usb controllers Peter Griffin
2014-11-10 10:06 ` Lee Jones
2014-11-07 11:57 ` [PATCH 10/13] ARM: STi: DT: STih410: Add dt nodes for the ehci / ohci " Peter Griffin
2014-11-10 9:26 ` Maxime Coquelin
2014-11-10 10:06 ` Lee Jones
2014-11-07 11:57 ` [PATCH 11/13] ARM: STi: DT: STih407: Abstract common dt nodes into shared files Peter Griffin
2014-11-07 12:10 ` Arnd Bergmann
2014-11-07 11:57 ` [PATCH 12/13] ARM: STi: DT: STiH410: Add STiH410 SoC clock support Peter Griffin
2014-11-07 12:13 ` Arnd Bergmann
2014-11-12 13:48 ` Peter Griffin
2014-11-10 9:20 ` Maxime Coquelin
2014-11-07 11:57 ` [PATCH 13/13] ARM: STi: DT: STih407: Add clk_ignore_unused to kernel bootargs Peter Griffin
2014-11-10 10:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113102218.GA25886@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox