linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller
Date: Thu, 13 Nov 2014 19:31:22 +0100	[thread overview]
Message-ID: <20141113183122.GH1275@katana> (raw)
In-Reply-To: <1415078977-18374-1-git-send-email-xudong.chen@mediatek.com>


> MTK I2C HW has some limitation.
> 1. If the i2c_msg number is more than one, STOP will be issued instead of
> RS(Repeat Start) between each message.
> 
> 2. Mediatek I2C controller support WRRD(write then read) mode, in WRRD
> mode the Repeat Start will be issued between 2 messages.
> In this driver if 2 messages is first write then read, the driver will
> combine 2 messages using Write-Read mode so the RS will be issued between
> the 2 messages.
> Ex: W/R/R, driver will combine first W/R and then R.
> 
> 3. Due to HW limitation, in this version the max transfer data length is 255
> in one message.

This looks to me more like an SMBUS controller instead of I2C. Maybe you
should populate smbus_xfer rather than master_xfer?

> MT8135 and MT6589 can control I2C pins on PMIC(MT6397) by setting the i2c
> registers in MT8135 side.

I still didn't get this, even after reading the mail thread of old
series. Can someone maybe draw me a nice ASCII picture showing the setup
which is going on here?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141113/3c345ed1/attachment.sig>

  parent reply	other threads:[~2014-11-13 18:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  5:29 [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek I2C controller Xudong Chen
2014-11-04  5:29 ` [PATCH v2 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx Xudong Chen
2014-11-13 18:16   ` Wolfram Sang
2014-11-14  3:13     ` xudong chen
2014-11-04  5:29 ` [PATCH v2 2/3] ARM: mediatek: Add I2C node for mt8135 and mt8127 Xudong Chen
2014-11-04  5:29 ` [PATCH v2 3/3] I2C: mediatek: Add driver for MediaTek I2C controller Xudong Chen
2014-11-13  2:08 ` [PATCH v2 0/3] ARM: mediatek: Add driver for Mediatek " xudong chen
2014-11-13 18:31 ` Wolfram Sang [this message]
2014-11-14  3:12   ` xudong chen
2014-11-14  8:00     ` Yingjoe Chen
2014-11-18 10:07     ` xudong chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113183122.GH1275@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).