[PATCH] dma: imx-sdma: clarify about firmware not found error

[PATCH] dma: imx-sdma: clarify about firmware not found error

[Fabio Estevam]

From: Sascha Hauer <s.hauer@pengutronix.de>

When a firmware cannot be found for the SDMA engine then we can
continue with the internal ROM firmware.

The meaning of this message is frequently asked for, so make clear
that the driver still works with the internal ROM firmware and reduce
the loglevel from err to info.

Cc: Vinod Koul <vinod.koul@intel.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/dma/imx-sdma.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 99d8833..2c67da5 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
 	unsigned short *ram_code;
 
 	if (!fw) {
-		dev_err(sdma->dev, "firmware not found\n");
+		dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
+		/* In this case we just use the ROM firmware. */
 		return;
 	}
 
-- 
1.9.1

[PATCH] dma: imx-sdma: clarify about firmware not found error

[Shawn Guo]

On Wed, Nov 12, 2014 at 08:04:29PM -0200, Fabio Estevam wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
> 
> When a firmware cannot be found for the SDMA engine then we can
> continue with the internal ROM firmware.
> 
> The meaning of this message is frequently asked for, so make clear
> that the driver still works with the internal ROM firmware and reduce
> the loglevel from err to info.
> 
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/dma/imx-sdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 99d8833..2c67da5 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1287,7 +1287,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
>  	unsigned short *ram_code;
>  
>  	if (!fw) {
> -		dev_err(sdma->dev, "firmware not found\n");
> +		dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
> +		/* In this case we just use the ROM firmware. */
>  		return;
>  	}
>  
> -- 
> 1.9.1
> 

[PATCH] dma: imx-sdma: clarify about firmware not found error

[Sascha Hauer]

On Wed, Nov 12, 2014 at 08:04:29PM -0200, Fabio Estevam wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
> 
> When a firmware cannot be found for the SDMA engine then we can
> continue with the internal ROM firmware.
> 
> The meaning of this message is frequently asked for, so make clear
> that the driver still works with the internal ROM firmware and reduce
> the loglevel from err to info.
> 
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

I still think we should have this.

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH] dma: imx-sdma: clarify about firmware not found error

[Fabio Estevam]

Hi Vinod,

On Mon, Nov 17, 2014 at 5:54 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Nov 12, 2014 at 08:04:29PM -0200, Fabio Estevam wrote:
>> From: Sascha Hauer <s.hauer@pengutronix.de>
>>
>> When a firmware cannot be found for the SDMA engine then we can
>> continue with the internal ROM firmware.
>>
>> The meaning of this message is frequently asked for, so make clear
>> that the driver still works with the internal ROM firmware and reduce
>> the loglevel from err to info.
>>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> I still think we should have this.
>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Could this one be applied?