From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio: mxs: implement get_direction callback
Date: Tue, 18 Nov 2014 08:55:45 +0100 [thread overview]
Message-ID: <20141118075545.GO27002@pengutronix.de> (raw)
In-Reply-To: <1416221256-11671-1-git-send-email-j.uzycki@elproma.com.pl>
Hello,
On Mon, Nov 17, 2014 at 11:47:36AM +0100, Janusz Uzycki wrote:
> gpiolib's gpiod_get_direction() function returns the EINVAL error
> if .get_direction callback is not defined.
> The patch implements the callback for mxs chip what is useful
s/what/which/
> for debugging.
>
> Commit f9e42397d79b
> ("serial: mxs-auart: add interrupts for modem control lines")
> as based on commit ab5e4e4108ca
> ("tty/serial: at91: add interrupts for modem control lines")
> uses the gpiod_get_direction() function.
This paragraph is obsolete now that we agreed that .get_direction has
nothing to do with mctrl_gpio, right?
>
> Inspired from arch/arm/mach-at91/gpio.c
s/from/by/ I think
Other than that:
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2014-11-18 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 10:47 [PATCH v2] gpio: mxs: implement get_direction callback Janusz Uzycki
2014-11-18 7:55 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118075545.GO27002@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).