linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sfr@canb.auug.org.au (Stephen Rothwell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: vfp: Silence mvfr0 unused variable warning
Date: Wed, 19 Nov 2014 08:14:38 +1100	[thread overview]
Message-ID: <20141119081438.3df66238@canb.auug.org.au> (raw)
In-Reply-To: <1416344191-20484-1-git-send-email-sboyd@codeaurora.org>

Hi Stephen,

On Tue, 18 Nov 2014 12:56:31 -0800 Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> Stephen Rothwell reports that commit 3f4c9f8f0a20 ("ARM: 8197/1:
> vfp: Fix VFPv3 hwcap detection on CPUID based cpus") introduced an
> unused variable warning.
> 
> arch/arm/vfp/vfpmodule.c: In function 'vfp_init':
> arch/arm/vfp/vfpmodule.c:725:6: warning: unused variable 'mvfr0'
> [-Wunused-variable]
>   u32 mvfr0;
> 
> Silence this warning by using IS_ENABLED instead of ifdefs.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Looks good (though I haven't tested it).  One small nit below:

> +		if (IS_ENABLED(CONFIG_VFPv3)) {
> +			mvfr0 = fmrx(MVFR0);

Now that you have a block here, you could move the declaration of mvfr0
into this block, right?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141119/6805172a/attachment-0001.sig>

  reply	other threads:[~2014-11-18 21:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 20:56 [PATCH] ARM: vfp: Silence mvfr0 unused variable warning Stephen Boyd
2014-11-18 21:14 ` Stephen Rothwell [this message]
2014-11-18 21:31   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119081438.3df66238@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).