[PATCH] ARM: dts: dove: add DT LCD controllers

[PATCH] ARM: dts: dove: add DT LCD controllers

[Russell King]

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
The documentation for this binding was submitted previously as part of
the code which parses this - v3.17-rc1~82^2~32^2~2.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller at 820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

[PATCH] ARM: dts: dove: add DT LCD controllers

[Jean-Francois Moine]

On Wed, 19 Nov 2014 11:32:29 +0000
Russell King <rmk+kernel@arm.linux.org.uk> wrote:

> +			lcd1: lcd-controller at 810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};

The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

[PATCH] ARM: dts: dove: add DT LCD controllers

[Russell King - ARM Linux]

On Wed, Nov 19, 2014 at 05:40:50PM +0100, Jean-Francois Moine wrote:
> On Wed, 19 Nov 2014 11:32:29 +0000
> Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> 
> > +			lcd1: lcd-controller at 810000 {
> > +				compatible = "marvell,dove-lcd";
> > +				reg = <0x810000 0x1000>;
> > +				interrupts = <46>;
> > +				status = "disabled";
> > +			};
> 
> The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

Actually, a more correct value would be 0x10000, if you read table 145.
Yes, the device may onlny have documented registers from 0x84 to 0x1c8,
but that isn't to say that we should say that the device resources
start at 0x810084 and have a size of 0x144, when the bus level decodes
a 64K chunk of memory.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

[PATCH] ARM: dts: dove: add DT LCD controllers

[Jason Cooper]

On Wed, Nov 19, 2014 at 11:32:29AM +0000, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> The documentation for this binding was submitted previously as part of
> the code which parses this - v3.17-rc1~82^2~32^2~2.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

hmmm... this was already applied:

  087b04701111e ARM: dts: dove: add DT LCD controllers

>From here:

  https://lkml.kernel.org/r/E1XAKGS-0004WE-8h at rmk-PC.arm.linux.org.uk

thx,

Jason.

[PATCH] ARM: dts: dove: add DT LCD controllers

[Russell King]

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
Jason,

David Airlie has taken the Armada DRM changes into his tree, so the DT
bits can now be queued for the next merge window.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller at 820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

[PATCH] ARM: dts: dove: add DT LCD controllers

[Sebastian Hesselbarth]

On 07/24/2014 04:45 PM, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

Thanks!

> ---
> Jason,
>
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
>
>   arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 3b891dd20993..a5441d5482a6 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -630,6 +630,20 @@
>   				reg = <0xe8400 0x0c>;
>   				ngpios = <8>;
>   			};
> +
> +			lcd1: lcd-controller at 810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};
> +
> +			lcd0: lcd-controller at 820000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x820000 0x1000>;
> +				interrupts = <47>;
> +				status = "disabled";
> +			};
>   		};
>   	};
>   };
>

[PATCH] ARM: dts: dove: add DT LCD controllers

[Jason Cooper]

On Thu, Jul 24, 2014 at 03:45:00PM +0100, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Jason,
> 
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Applied to mvebu/dt with Sebastian's Ack.

thx,

Jason.