From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 20 Nov 2014 00:07:36 +0000 Subject: [PATCH v9 05/13] arm: introduce is_device_dma_coherent In-Reply-To: References: <1415792454-23161-5-git-send-email-stefano.stabellini@eu.citrix.com> Message-ID: <20141120000736.GN4042@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote: > ping? Sending something which wants my attention _To:_ me is always a good idea :) The patch is fine in itself, but I have a niggle about the is_device_dma_coherent() - provided this is only used in architecture specific code, that should be fine. It could probably do with a comment to that effect in an attempt to discourage drivers using it (thereby becoming less portable to other architectures.) -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.