From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 05/13] arm: introduce is_device_dma_coherent
Date: Fri, 21 Nov 2014 15:29:09 +0000 [thread overview]
Message-ID: <20141121152908.GU4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1411201036400.12596@kaball.uk.xensource.com>
On Thu, Nov 20, 2014 at 10:39:32AM +0000, Stefano Stabellini wrote:
> On Thu, 20 Nov 2014, Russell King - ARM Linux wrote:
> > On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote:
> > > ping?
> >
> > Sending something which wants my attention _To:_ me is always a good idea :)
>
> I'll keep that in mind :-)
>
>
> > The patch is fine in itself, but I have a niggle about the
> > is_device_dma_coherent() - provided this is only used in architecture
> > specific code, that should be fine. It could probably do with a comment
> > to that effect in an attempt to discourage drivers using it (thereby
> > becoming less portable to other architectures.)
>
> Can I take this as an Acked-by?
> Good point regarding the comment. Maybe I can add:
>
> /* do not use this function in a driver */
Provided it gets such a comment, yes. Thanks.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-11-21 15:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:39 [PATCH v9 0/13] introduce GNTTABOP_cache_flush Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 01/13] xen/arm: remove handling of XENFEAT_grant_map_identity Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 02/13] xen/arm: remove outer_*_range call Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 03/13] xen/arm: if(pfn_valid(pfn)) call native dma_ops Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 04/13] arm64: introduce is_device_dma_coherent Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 05/13] arm: " Stefano Stabellini
2014-11-14 11:59 ` Stefano Stabellini
2014-11-18 16:49 ` Stefano Stabellini
2014-11-20 0:07 ` Russell King - ARM Linux
2014-11-20 10:39 ` Stefano Stabellini
2014-11-21 15:29 ` Russell King - ARM Linux [this message]
2014-11-12 11:40 ` [PATCH v9 06/13] xen/arm: use is_device_dma_coherent Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 07/13] xen: add a dma_addr_t dev_addr argument to xen_dma_map_page Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 08/13] xen/arm: use hypercall to flush caches in map_page Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 09/13] xen/arm/arm64: merge xen/mm32.c into xen/mm.c Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 10/13] xen/arm/arm64: introduce xen_arch_need_swiotlb Stefano Stabellini
2014-11-21 16:31 ` Stefano Stabellini
2014-11-21 16:48 ` Konrad Rzeszutek Wilk
2014-11-12 11:40 ` [PATCH v9 11/13] xen/arm: introduce GNTTABOP_cache_flush Stefano Stabellini
2014-11-12 11:40 ` [PATCH v9 12/13] swiotlb-xen: pass dev_addr to xen_dma_unmap_page and xen_dma_sync_single_for_cpu Stefano Stabellini
2014-11-19 21:07 ` Konrad Rzeszutek Wilk
2014-11-20 10:33 ` Stefano Stabellini
2014-11-20 10:47 ` Stefano Stabellini
2014-11-20 20:30 ` Konrad Rzeszutek Wilk
2014-11-12 11:40 ` [PATCH v9 13/13] swiotlb-xen: remove BUG_ON in xen_bus_to_phys Stefano Stabellini
2014-11-19 21:06 ` Konrad Rzeszutek Wilk
2014-11-12 14:22 ` [Xen-devel] [PATCH v9 0/13] introduce GNTTABOP_cache_flush Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121152908.GU4042@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).