linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header
Date: Fri, 21 Nov 2014 08:55:35 -0800	[thread overview]
Message-ID: <20141121165535.GT7046@atomide.com> (raw)
In-Reply-To: <20141121161529.GQ7046@atomide.com>

* Tony Lindgren <tony@atomide.com> [141121 08:18]:
> * Roger Quadros <rogerq@ti.com> [141121 01:30]:
> > On 11/21/2014 12:28 AM, Tony Lindgren wrote:
> > > +#include <linux/omap-gpmc.h>
> > > +#include <linux/platform_data/omap-gpmc.h>
> > 
> > I think we should get rid for mach-omap2/gpmc.h and include the above two
> > headers wherever needed.
> 
> Well I'm trying to keep the churn on patching all board-*.c files
> down to minimum until they just get dropped.
> 
> So let's keep gpmc.h around still for a little while for all the
> board-*.c files.
>  
> > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> > > index 175564c..88721df 100644
> > > --- a/arch/arm/mach-omap2/pm34xx.c
> > > +++ b/arch/arm/mach-omap2/pm34xx.c
> > > @@ -29,6 +29,7 @@
> > >  #include <linux/delay.h>
> > >  #include <linux/slab.h>
> > >  #include <linux/omap-dma.h>
> > > +#include <linux/omap-gpmc.h>
> > >  #include <linux/platform_data/gpio-omap.h>
> > >  
> > >  #include <trace/events/power.h>
> > > @@ -43,7 +44,6 @@
> > >  #include "common.h"
> > >  #include "cm3xxx.h"
> > >  #include "cm-regbits-34xx.h"
> > > -#include "gpmc.h"
> > >  #include "prm-regbits-34xx.h"
> > >  #include "prm3xxx.h"
> > >  #include "pm.h"
> 
> And for the files that will stay around, let's not include gpmc.h.

After updating this patch to remove include of gpmc.h in any files
this patch touches, we still have gpmc.h left in 11 files we're not
touching right now. If we want to patch those, we can do it later on
in a separate patch to avoid creating more dependencies between
branches.

Regards,

Tony

  reply	other threads:[~2014-11-21 16:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 22:28 [PATCH 0/3] Move omap GPMC to live in drivers/bus Tony Lindgren
2014-11-20 22:28 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-21  9:28   ` Roger Quadros
2014-11-21 16:15     ` Tony Lindgren
2014-11-21 16:55       ` Tony Lindgren [this message]
2014-11-20 22:28 ` [PATCH 2/3] ARM: OMAP2+: Move GPMC initcall to devices.c Tony Lindgren
2014-11-21  9:41   ` Roger Quadros
2014-11-21 16:17     ` Tony Lindgren
2014-11-20 22:28 ` [PATCH 3/3] drivers: bus: Move omap gpmc code to live under drivers Tony Lindgren
2014-11-21  8:05   ` Lokesh Vutla
2014-11-21 17:18     ` Tony Lindgren
2014-11-21  9:15   ` Roger Quadros
2014-11-21 11:15     ` Arnd Bergmann
2014-11-21 16:18       ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2014-11-21 18:34 [PATCHv2 0/3] Move omap GPMC to live in drivers/memory Tony Lindgren
2014-11-21 18:34 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-26 11:28   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141121165535.GT7046@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).