From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
Date: Fri, 21 Nov 2014 14:31:07 -0400 [thread overview]
Message-ID: <20141121183105.GA10652@developer> (raw)
In-Reply-To: <20141119164040.GG1875@x1>
Hello Lee,
On Wed, Nov 19, 2014 at 04:40:40PM +0000, Lee Jones wrote:
> On Wed, 19 Nov 2014, Fabio Estevam wrote:
>
> > On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > > Prevents build warning:
> > >
> > > st_thermal.c:278:12:
> > > warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> > > st_thermal.c:286:12:
> > > warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >
> > > v1 => v2:
> > > - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
> >
> > You should also update the Subject to 'when !PM_SLEEP'
>
> I guess we should, yes.
>
> Zhang, Eduardo,
>
> Are you happy to do that, or would you like me to re-spin again?
>
I can edit the patch for you this time.
Next time, when sending new versions, a couple of advices:
(1) add the Ack's/Reviewed's/Tested's -by you get along the way.
(2) please, version you patches, it easies maintainter's life while
reviewing / applying your patches.
Thanks for sending the fix.
Eduardo Valentin
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org ? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141121/0449ed82/attachment.sig>
next prev parent reply other threads:[~2014-11-21 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 15:50 [PATCH] thermal: sti: Ignore suspend/resume functions when !PM Lee Jones
2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:40 ` Lee Jones
2014-11-21 18:31 ` Eduardo Valentin [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-19 13:48 Lee Jones
2014-11-19 14:57 ` Fabio Estevam
2014-11-19 15:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121183105.GA10652@developer \
--to=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).