From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/6] arm64: Add framework for legacy instruction emulation
Date: Tue, 25 Nov 2014 10:07:59 +0000 [thread overview]
Message-ID: <20141125100759.GA30251@arm.com> (raw)
In-Reply-To: <CAJKQeMZE_akWY39U3X3a1_-co3da2H03kUkOsZ_5CLrwMn-=wA@mail.gmail.com>
On Mon, Nov 24, 2014 at 08:58:33PM +0000, Greg Hackmann wrote:
> If it's not too late to chime in, I ran across one issue testing this patchset:
>
> On Tue, Nov 18, 2014 at 3:41 AM, Punit Agrawal <punit.agrawal@arm.com> wrote:
> > + ret = update_insn_emulation_mode(insn, prev_mode);
> > + if (!ret) {
> > + /* Mode change failed, revert to previous mode. */
> > + insn->current_mode = prev_mode;
> > + update_insn_emulation_mode(insn, INSN_UNDEF);
> > + }
>
> update_insn_emulation_mode() returns 0 on success, so the condition
> needs to be "if (ret)". Otherwise writes to the sysctl file are
> immediately rolled back.
Thanks Gene, I'll add that on top with your reported-by.
Will
next prev parent reply other threads:[~2014-11-25 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 11:41 [PATCH v5 0/6] Legacy instruction emulation for arm64 Punit Agrawal
2014-11-18 11:41 ` [PATCH v5 1/6] arm64: Add support for hooks to handle undefined instructions Punit Agrawal
2014-11-18 11:41 ` [PATCH v5 2/6] arm64: Add AArch32 instruction set condition code checks Punit Agrawal
2014-11-18 11:41 ` [PATCH v5 3/6] arm64: Add framework for legacy instruction emulation Punit Agrawal
2014-11-20 16:30 ` Catalin Marinas
2014-11-24 20:58 ` Greg Hackmann
2014-11-25 10:07 ` Will Deacon [this message]
2014-11-25 10:13 ` Punit Agrawal
2014-11-18 11:41 ` [PATCH v5 4/6] arm64: Port SWP/SWPB emulation support from arm Punit Agrawal
2014-11-20 16:31 ` Catalin Marinas
2014-11-18 11:41 ` [PATCH v5 5/6] arm64: Emulate CP15 Barrier instructions Punit Agrawal
2014-11-18 11:41 ` [PATCH v5 6/6] arm64: Trace emulation of AArch32 legacy instructions Punit Agrawal
2014-11-18 14:32 ` Steven Rostedt
2014-11-18 14:51 ` Punit Agrawal
2014-11-20 16:33 ` [PATCH v5 0/6] Legacy instruction emulation for arm64 Catalin Marinas
2014-11-24 19:24 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125100759.GA30251@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).