linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode
Date: Thu, 27 Nov 2014 00:38:01 +0100	[thread overview]
Message-ID: <201411270038.01312@pali> (raw)
In-Reply-To: <20141126231435.GQ2817@atomide.com>

On Thursday 27 November 2014 00:14:36 Tony Lindgren wrote:
> * Pali Roh?r <pali.rohar@gmail.com> [141126 15:03]:
> > On Wednesday 26 November 2014 21:08:06 Tony Lindgren wrote:
> > 
> > With your patch I'm getting:
> > 
> > Hardware        : Nokia RX-51 board
> > 
> > So patch is good.
> 
> Is that a Tested-by: then? :)
> 

Yes for Hardware line you can add my:

Tested-by: Pali Roh?r <pali.rohar@gmail.com>

> > > > Revision comes from bootloader (via ATAG) and it is HW
> > > > revision of N900 device. It cannot be hardcoded into
> > > > kernel or DTS as it it depends on HW.
> > > 
> > > Well for the "Revision" line problem, we could pass the
> > > revision in cmdline or .dts if not passed in the legacy
> > > ATAGs. It sounds like were just not copying it to
> > > system_rev for DT based booting? Maybe it's just some
> > > missing CONFIG_ATAG option that needs to be enabled?
> > 
> > Yes it looks like DT code does not read Revision ATAG... I
> > tried to enable everything but always same problem...
> 
> Maybe check if it shows up properly in /proc/atags or whatever
> the interface for it was?
> 

With enabled CONFIG_ARM_APPENDED_DTB=y file /proc/atags is 
missing.

> The build_tag_list() should parse ATAG_REVISION and then
> parse_tag_revision() should copy it to system_rev. Maybe try
> adding some printks to see if those functions get called?
> 
> Regards,
> 
> Tony

Now I see... Problem is that build_tag_list() is called from 
convert_to_tag_list() which is called from setup_machine_tags() 
which is called from setup_arch() only if setup_machine_fdt() 
call fails. And it fails for *non* DT boot. You can check this 
chain too.

-- 
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141127/c8e39090/attachment.sig>

  reply	other threads:[~2014-11-26 23:38 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 20:00 [PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode Tony Lindgren
2014-10-27 23:01 ` Aaro Koskinen
2014-10-28 22:12   ` Tony Lindgren
2014-10-29 13:43     ` Nishanth Menon
2014-10-29 18:59       ` Sebastian Reichel
2014-10-29 19:39         ` Tony Lindgren
2014-10-29 21:45           ` Nishanth Menon
2014-10-29 22:15             ` Tony Lindgren
2014-10-29 22:31             ` Aaro Koskinen
2014-10-30 13:55               ` Nishanth Menon
2014-10-29 23:07           ` Sebastian Reichel
2014-10-29 23:11           ` Aaro Koskinen
2014-10-29 23:54             ` Javier Martinez Canillas
2014-11-26 17:28   ` Pavel Machek
2014-11-26 18:19     ` Tony Lindgren
2014-11-26 18:57       ` Pali Rohár
2014-11-26 19:10         ` Tony Lindgren
2014-11-26 19:22           ` Pali Rohár
2014-11-26 20:08             ` Tony Lindgren
2014-11-26 23:01               ` Pali Rohár
2014-11-26 23:14                 ` Tony Lindgren
2014-11-26 23:38                   ` Pali Rohár [this message]
2014-11-27  1:12                     ` Tony Lindgren
2014-11-27 11:32                       ` Pali Rohár
2014-11-28 20:27                         ` Tony Lindgren
2014-11-28 21:41                           ` Pali Rohár
2014-11-28 22:24                             ` Tony Lindgren
2014-11-28 22:42                               ` Pali Rohár
2014-12-04 18:34                               ` Pali Rohár
2014-12-04 18:40                                 ` Tony Lindgren
2014-12-04 19:01                                   ` Pali Rohár
2014-11-28 22:26                             ` Aaro Koskinen
2014-11-28 22:43                               ` Pali Rohár
2014-11-28 22:41                             ` Aaro Koskinen
2014-11-28 22:49                               ` Pali Rohár
2014-11-28 22:54                                 ` Aaro Koskinen
2014-12-02 21:28                           ` Pali Rohár
2014-12-03 16:52                           ` Pavel Machek
2014-11-27 11:18               ` Pavel Machek
2014-10-31 19:30 ` Russell King - ARM Linux
2014-10-31 21:13   ` Tony Lindgren
2014-10-31 22:12     ` Tony Lindgren
2014-10-31 22:33     ` Russell King - ARM Linux
2014-10-31 23:37       ` Tony Lindgren
2014-11-01  0:44         ` Russell King - ARM Linux
2014-11-01 21:57           ` Tony Lindgren
2014-11-02 18:15             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201411270038.01312@pali \
    --to=pali.rohar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).