From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 27 Nov 2014 08:36:29 +0000 Subject: [PATCH v2 3/9] clk: sunxi: Add prcm mod0 clock driver In-Reply-To: <547589A9.5060802@redhat.com> References: <1416749895-25013-1-git-send-email-hdegoede@redhat.com> <1416749895-25013-4-git-send-email-hdegoede@redhat.com> <20141125165744.GA17789@x1> <547589A9.5060802@redhat.com> Message-ID: <20141127083629.GA4628@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 26 Nov 2014, Hans de Goede wrote: > Hi, > > On 11/25/2014 05:57 PM, Lee Jones wrote: > >On Sun, 23 Nov 2014, Hans de Goede wrote: > > > >>Add a driver for mod0 clocks found in the prcm. Currently there is only > >>one mod0 clocks in the prcm, the ir clock. > >> > >>Signed-off-by: Hans de Goede > >>--- > >> Documentation/devicetree/bindings/clock/sunxi.txt | 1 + > >> drivers/clk/sunxi/Makefile | 2 +- > >> drivers/clk/sunxi/clk-sun6i-prcm-mod0.c | 63 +++++++++++++++++++++++ > >> drivers/mfd/sun6i-prcm.c | 14 +++++ > >> 4 files changed, 79 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/clk/sunxi/clk-sun6i-prcm-mod0.c > > > >[...] > > > >>diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c > >>index 283ab8d..ff1254f 100644 > >>--- a/drivers/mfd/sun6i-prcm.c > >>+++ b/drivers/mfd/sun6i-prcm.c > >>@@ -41,6 +41,14 @@ static const struct resource sun6i_a31_apb0_gates_clk_res[] = { > >> }, > >> }; > >> > >>+static const struct resource sun6i_a31_ir_clk_res[] = { > >>+ { > >>+ .start = 0x54, > >>+ .end = 0x57, > >>+ .flags = IORESOURCE_MEM, > >>+ }, > >>+}; > > > >I'm not overly keen on these magic numbers (and yes, I'm well aware > >that I SoB'ed the patch which started them off). > > > >It's not a show stopper, although I'd prefer if they were fixed with a > >subsequent patch. > > These are offsets of the relevant registers inside the prcm register block, > if not done this way, then how should they be done ? I like these kinds of things to be defined. No implementation changes are necessary. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog