From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: cacheflush: get rid of restarting block
Date: Thu, 27 Nov 2014 10:03:06 +0000 [thread overview]
Message-ID: <20141127100306.GA20649@arm.com> (raw)
In-Reply-To: <005b01d009f6$f3c6a0f0$db53e2d0$@min@lge.com>
On Thu, Nov 27, 2014 at 04:02:24AM +0000, Chanho Min wrote:
> > -----Original Message-----
> > From: Vladimir Murzin [mailto:vladimir.murzin at arm.com]
> > Sent: Wednesday, November 26, 2014 12:19 AM
> > To: linux-arm-kernel at lists.infradead.org; linux at arm.linux.org.uk
> > Cc: chanho.min at lge.com; will.deacon at arm.com; stable at vger.kernel.org
> > Subject: [PATCH] arm: cacheflush: get rid of restarting block
> >
> > We cannot restart cacheflush safely if a process provides user-defined
> > signal handler and signal is pending. In this case -EINTR is returned
> > and it is expected that process re-invokes syscall. However, there are
> > a few problems with that:
> > * looks like nobody bothers checking return value from cacheflush
> > * but if it did, we don't provide the restart address for that, so the
> > process has to use the same range again
> > * ...and again, what might lead to looping forever
> >
> > So, remove cacheflush restarting code and terminate cache flushing
> > as early as fatal signal is pending.
> >
> > Cc: stable at vger.kernel.org # 3.12+
> > Reported-by: Chanho Min <chanho.min@lge.com>
> > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> > Acked-by: Will Deacon <will.deacon@arm.com>
> > ---
> > Hi,
> >
> > There is my proposal for the problem reported in [1]. Since that
> > thread has not been progressing much, I'm addressing the problem in
> > separate patch.
> >
> > Comments?
> Thanks, We hope this to be applied.
Ok, good. In which case, can you put it into the patch system please,
Vladimir?
Will
next prev parent reply other threads:[~2014-11-27 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 15:18 [PATCH] arm: cacheflush: get rid of restarting block Vladimir Murzin
2014-11-27 4:02 ` Chanho Min
2014-11-27 10:03 ` Will Deacon [this message]
2014-11-27 10:43 ` Vladimir Murzin
2014-11-27 10:45 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127100306.GA20649@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).