From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: ARM: Fix the Generic Timers interrupt active level description
Date: Fri, 28 Nov 2014 11:12:52 +0800 [thread overview]
Message-ID: <20141128111252.4a6e8892@xhacker> (raw)
In-Reply-To: <54776FE0.8030600@arm.com>
Dear Marc and Liviu,
On Thu, 27 Nov 2014 10:39:28 -0800
Marc Zyngier <marc.zyngier@arm.com> wrote:
> On 27/11/14 16:21, Liviu Dudau wrote:
> > The Cortex-A5x TRM states in paragraph "9.2 Generic Timer functional
> > description" that generic timers provide a level not edge interrupt
> > output. Fix the device trees to correctly describe this.
> >
> > While doing this update the CPU mask to match the number of described
> > CPUs as well as the DT bindings documentation for Generic Timers.
> >
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
> M.
>
> > ---
> >
> > Arnd, Olof: This is on top of linux-next/master as it patches Juno's
> > as well as all the other ARM DTs.
> >
> > --
> >
> > Documentation/devicetree/bindings/arm/arch_timer.txt | 8 ++++----
> > arch/arm64/boot/dts/arm/foundation-v8.dts | 8 ++++----
> > arch/arm64/boot/dts/arm/juno.dts | 8 ++++----
> > arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 8 ++++----
> > 4 files changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/arch_timer.txt
> > b/Documentation/devicetree/bindings/arm/arch_timer.txt index
> > 37b2caf..6d2aa87 100644 ---
> > a/Documentation/devicetree/bindings/arm/arch_timer.txt +++
> > b/Documentation/devicetree/bindings/arm/arch_timer.txt @@ -27,10 +27,10
> > @@ Example: timer {
> > compatible = "arm,cortex-a15-timer",
> > "arm,armv7-timer";
> > - interrupts = <1 13 0xf08>,
> > - <1 14 0xf08>,
> > - <1 11 0xf08>,
> > - <1 10 0xf08>;
> > + interrupts = <1 13 0xf04>,
> > + <1 14 0xf04>,
> > + <1 11 0xf04>,
> > + <1 10 0xf04>;
> > clock-frequency = <100000000>;
> > };
> >
Does it mean we also need to fix the interrupt level description under
arch/arm/boot/dts? I found they are also wrong or I misunderstand something?
Thanks,
Jisheng
next prev parent reply other threads:[~2014-11-28 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 16:21 [PATCH v2] arm64: ARM: Fix the Generic Timers interrupt active level description Liviu Dudau
2014-11-27 18:39 ` Marc Zyngier
2014-11-28 3:12 ` Jisheng Zhang [this message]
2014-11-28 10:38 ` Liviu Dudau
2014-11-28 10:51 ` Jisheng Zhang
2014-11-28 10:56 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128111252.4a6e8892@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).