From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: enable ARCH_HAS_BANDGAP config
Date: Fri, 28 Nov 2014 14:12:41 +0000 [thread overview]
Message-ID: <20141128141240.GA4249@localhost> (raw)
In-Reply-To: <CAGOxZ52o-O+=PCsGRfKEGGc0NUg_M+z5_UmbrjBwvW8+x3c22w@mail.gmail.com>
On Sun, Nov 23, 2014 at 08:05:05AM +0000, Alim Akhtar wrote:
> On Fri, Nov 14, 2014 at 6:00 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
> > Some of the existing thermal drivers (ti and exynos) have a dependency on
> > ARCH_HAS_BANDGAP. Activate ARCH_HAS_BANDGAP config entry for ARM64 so that
> > these drivers may be re-used.
> >
> > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> > ---
> HAS_BANDGAP was added to ARM to indicate that arch supports a bandgap
> device like a thermal management unit, so this looks good to me.
But it doesn't look good to me. ARCH_HAS_* kind of implies that the
architecture has some feature or the port provides some feature. But in
the current use, it simply allows the enabling of the menu config
entries for two drivers (EXYNOS_THERMAL and TI_SOC_THERMAL).
If you want to specify that the SoC has a device, just use DT and not
some random config option that only enables the menu entry for the
corresponding driver.
--
Catalin
next prev parent reply other threads:[~2014-11-28 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 12:30 [PATCH] arm64: enable ARCH_HAS_BANDGAP config Abhilash Kesavan
2014-11-23 8:05 ` Alim Akhtar
2014-11-28 14:12 ` Catalin Marinas [this message]
2014-11-28 14:39 ` Abhilash Kesavan
2014-11-28 15:15 ` Catalin Marinas
2014-12-02 13:41 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128141240.GA4249@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).