From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers
Date: Fri, 28 Nov 2014 14:16:48 +0000 [thread overview]
Message-ID: <20141128141648.GB4249@localhost> (raw)
In-Reply-To: <5475CC66.6080600@linaro.org>
On Wed, Nov 26, 2014 at 12:49:42PM +0000, Daniel Lezcano wrote:
> On 10/08/2014 09:33 AM, Sonny Rao wrote:
> > From: Doug Anderson <dianders@chromium.org>
> >
> > Some 32-bit (ARMv7) systems are architected like this:
> >
> > * The firmware doesn't know and doesn't care about hypervisor mode and
> > we don't want to add the complexity of hypervisor there.
> >
> > * The firmware isn't involved in SMP bringup or resume.
> >
> > * The ARCH timer come up with an uninitialized offset (CNTVOFF)
> > between the virtual and physical counters. Each core gets a
> > different random offset.
> >
> > * The device boots in "Secure SVC" mode.
> >
> > * Nothing has touched the reset value of CNTHCTL.PL1PCEN or
> > CNTHCTL.PL1PCTEN (both default to 1 at reset)
> >
> > On systems like the above, it doesn't make sense to use the virtual
> > counter. There's nobody managing the offset and each time a core goes
> > down and comes back up it will get reinitialized to some other random
> > value.
> >
> > This adds an optional property which can inform the kernel of this
> > situation, and firmware is free to remove the property if it is going
> > to initialize the CNTVOFF registers when each CPU comes out of reset.
> >
> > Currently, the best course of action in this case is to use the
> > physical timer, which is why it is important that CNTHCTL hasn't been
> > changed from its reset value and it's a reasonable assumption given
> > that the firmware has never entered HYP mode.
> >
> > Note that it's been said that on ARMv8 systems the firmware and
> > kernel really can't be architected as described above. That means
> > using the physical timer like this really only makes sense for ARMv7
> > systems.
> >
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
> > Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
> > Reviewed-by: Mark Rutland <mark.rutland@arm.com>
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> I would be nice to have Catalin's ack.
FWIW:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2014-11-28 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 7:33 [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers Sonny Rao
2014-11-19 23:01 ` Doug Anderson
2014-11-23 21:41 ` Daniel Lezcano
2014-11-26 11:51 ` Daniel Lezcano
2014-11-26 12:06 ` Heiko Stübner
2014-11-26 12:30 ` Daniel Lezcano
2014-11-26 12:48 ` Heiko Stübner
2014-11-26 12:49 ` Daniel Lezcano
2014-11-26 12:55 ` Heiko Stübner
2014-11-26 12:53 ` Daniel Lezcano
2014-11-26 12:49 ` Daniel Lezcano
2014-11-28 14:16 ` Catalin Marinas [this message]
2014-11-26 14:41 ` Yingjoe Chen
2014-11-26 16:14 ` Doug Anderson
2014-11-27 2:27 ` Yingjoe Chen
2014-12-05 7:34 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128141648.GB4249@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).